feat: add Stackbit 1248 vertical layout for backup display#847
Draft
bitcoisas wants to merge 4 commits intoselfcustody:developfrom
Draft
feat: add Stackbit 1248 vertical layout for backup display#847bitcoisas wants to merge 4 commits intoselfcustody:developfrom
bitcoisas wants to merge 4 commits intoselfcustody:developfrom
Conversation
Add export_1248_vertical_grouped and export_1248_vertical_compact methods to the Stackbit class for the vertical backup layout. Part of issue selfcustody#834.
Add layout selection submenu with Standard and Vertical options. Vertical uses grouped layout for all devices and compact layout for M5StickV. Part of issue selfcustody#834.
Cover vertical grouped layout (Amigo) and vertical compact layout (M5StickV) with full 24-word mnemonic pagination. Part of issue selfcustody#834.
bitcoisas
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #847 +/- ##
===========================================
+ Coverage 97.31% 97.33% +0.02%
===========================================
Files 83 83
Lines 10573 10743 +170
===========================================
+ Hits 10289 10457 +168
- Misses 284 286 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR adds vertical layout support for Stackbit 1248 backup display.
Currently, the Stackbit 1248 grid only supports the horizontal layout (rows = digits, columns = weights 1/2/4/8). This adds a menu to choose between "Standard" (horizontal) and "Vertical" (rows = weights, columns = digits), which is essentially the transposition of the grid.
This PR covers the backup/display side only. The input/loading side will be addressed in a separate PR as discussed with maintainers.
Close #834
Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?
Screenshots (not the same words on the devices):
After selecting Stackbit 1248 on menu:
Choosing Standard:
Choosing Vertical: