Skip to content

Feature: Sound Notifications - #6

Merged
semanticdata merged 15 commits into
masterfrom
feature/sound-notifications
Aug 26, 2025
Merged

Feature: Sound Notifications#6
semanticdata merged 15 commits into
masterfrom
feature/sound-notifications

Conversation

@semanticdata

Copy link
Copy Markdown
Owner

Changed

  • Simplified audio loading logic by removing complex local file path resolution.
  • Updated all dependencies to latest versions.
  • Replaced Settings Headings with proper setHeading() method for Obsidian plugin guidelines compliance.

Fixed

  • Updated test mocks to support new setHeading() method.
  • Corrected test expectations and setting indices after settings UI restructure.
  • Fixed lint errors in sound manager.

Added

  • New optional notification sound at the end of the timer.
    • Audio notifications load from CDN for improved reliability and cross-platform compatibility.
    • Option to use Custom URL or File instead of the default options.
  • New Obsidian command to toggle Sound Notifications on and off.

Screenshots

Settings
image

@semanticdata semanticdata added the enhancement New feature or request label Aug 18, 2025
@Sanctom

Sanctom commented Aug 23, 2025

Copy link
Copy Markdown

Test report (macOS / Obsidian Desktop)
Environment
– Obsidian v1.9.10, macOS 12.7.6 (Intel MacPro)
– Node v22.18.0, npm 10.9.3, pnpm 10.15.0
– Branch: pr-6

What I tested
– End-of-timer sound (default/CDN).
– Sound toggle in Settings and via the new command.
– Custom URL and Local file playback.
– Settings headings via setHeading().
pnpm build succeeded; tests passed locally.

Results
– ✅ All checks passed; feature behaves as expected.

From my perspective this resolves #5.
Thanks for implementing this — everything looks solid on my end.
Appreciate the work.

@semanticdata
semanticdata merged commit b4d24f5 into master Aug 26, 2025
2 checks passed
@semanticdata
semanticdata deleted the feature/sound-notifications branch August 26, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants