Skip to content

fix(scripts): replaced map with foreach func #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

fix(scripts): replaced map with foreach func #1061

merged 1 commit into from
Oct 23, 2025

Conversation

@CristianPerez06
Copy link
Contributor

@CristianPerez06 CristianPerez06 commented Oct 22, 2025

re #1056

Scripts folder - Replaced map with forEach functions
Related issue -> #1056

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@CristianPerez06 CristianPerez06 requested a review from a team as a code owner October 22, 2025 23:03
vplasencia
vplasencia approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you very much @CristianPerez06 🚀

@vplasencia vplasencia merged commit 496e18e into semaphore-protocol:main Oct 23, 2025
2 of 4 checks passed
@gitpoap-bot
Copy link

gitpoap-bot bot commented Oct 23, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Semaphore Contributor:

GitPOAP: 2025 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@vplasencia vplasencia linked an issue Oct 23, 2025 that may be closed by this pull request
Replace map() with forEach() #1056
Closed
This was referenced Oct 23, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vplasencia vplasencia vplasencia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace map() with forEach()

2 participants

@CristianPerez06 @vplasencia