Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@CodeShadower is attempting to deploy a commit to the heyamica Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughAdds French language support by updating the i18next parser locales, registering French in the language registry, and adding a new French translation JSON resource. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
i18next-parser.config.mjs(1 hunks)src/i18n/langs.ts(2 hunks)src/i18n/locales/fr/common.json(1 hunks)
🔇 Additional comments (3)
src/i18n/langs.ts (2)
5-5: LGTM!The French locale import follows the established pattern and is correctly placed.
28-31: LGTM!The French locale registration is correctly structured with the proper native name "Français" and follows the same pattern as other locales.
i18next-parser.config.mjs (1)
5-5: LGTM!The addition of 'fr' to the locales array correctly configures i18next-parser to recognize and process French translations.
| "VRM upload message": "Message de téléchargement VRM", | ||
| "VRM local share message": "Message de partage local de VRM", |
There was a problem hiding this comment.
Translate the placeholder values.
These entries contain English placeholder text instead of French translations. They should be translated to maintain consistency with the rest of the locale file.
🔎 Suggested translations
- "VRM upload message": "Message de téléchargement VRM",
- "VRM local share message": "Message de partage local de VRM",
+ "VRM upload message": "Téléchargez un fichier VRM pour personnaliser votre avatar. Les fichiers VRM sont des modèles 3D qui définissent l'apparence de votre personnage.",
+ "VRM local share message": "Le modèle VRM sera stocké localement sur votre appareil et ne sera pas téléchargé sur un serveur.",Note: Please verify these translations match the actual English message content from the en/common.json file, as the keys suggest they should contain longer explanatory messages rather than simple labels.
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In src/i18n/locales/fr/common.json around lines 149 to 150 the values for "VRM
upload message" and "VRM local share message" are still English placeholders;
replace them with proper French translations that correspond to the full English
messages in en/common.json (open en/common.json to copy the exact source text,
translate that text into French preserving meaning and placeholders), update the
two JSON string values accordingly, and ensure punctuation/escaping and JSON
syntax remain valid.
Initial version was messed up somehow.
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (2)
src/i18n/locales/fr/common.json (2)
1-227: Key inconsistencies between French and English locales remain unresolved.As previously flagged, the French locale file contains a different set of keys than the English locale (154 vs 149 keys). Please ensure all locale files maintain identical key sets for consistency by adding missing keys from English and removing or reconciling French-only keys.
203-204: Complete the placeholder translations for VRM messages.As previously noted, these entries appear to contain label translations rather than the full explanatory message content that should correspond to the English locale. Please verify the actual English message content from
en/common.jsonand provide complete French translations.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/i18n/locales/fr/common.json(1 hunks)
🧰 Additional context used
🪛 Biome (2.1.2)
src/i18n/locales/fr/common.json
[error] 128-129: expected , but instead found "Loading..."
Remove "Loading..."
(parse)
[error] 215-215: expected , but instead found "Idle text prompt"
Remove "Idle text prompt"
(parse)
1 participant
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.