Skip to content

[UIK-5136][slider] rewrite component to TS#2918

Open
slizhevskyv-semrush wants to merge 2 commits into
release/v17from
UIK-5136/rewrite-component-to-ts
Open

[UIK-5136][slider] rewrite component to TS#2918
slizhevskyv-semrush wants to merge 2 commits into
release/v17from
UIK-5136/rewrite-component-to-ts

Conversation

@slizhevskyv-semrush
Copy link
Copy Markdown
Contributor

Changelog

@semcore/slider

Fixed

  • Rewrite component to TS. Deprecate atomic types. Atomic types are part of NSSlider namespace.

Motivation and Context

Rewrite component to TS. Deprecate atomic types in favor of namespaces. Nothing changed in how component works. (I hope :D)

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

Copy link
Copy Markdown
Contributor Author

@slizhevskyv-semrush slizhevskyv-semrush May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilyabrower there is a small forced refactoring... idk 🤷‍♂️
I added fallback values for NaN values. Please, let me know whether it makes sense :) Overall looks like legit since options variant is used through indexes...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm... as I see, you don't need this fallback logic, because you defined defaultProps, so, in every this.props.min you will have defined value...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants