Skip to content

[chore] moved FeatureHightlight to Dashboard to fix rendering in astro #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Valeria-Zimnitskaya merged 1 commit into from
May 13, 2026
+15 −17
Merged

[chore] moved FeatureHightlight to Dashboard to fix rendering in astro #2925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions stories/patterns/core/tests/all-components/components/Dashboard/Dashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ import CigaretteMockData from '../../../../../../components/d3-chart/__mocks__/c
import DonutMockData from '../../../../../../components/d3-chart/__mocks__/donut';
import ScatterplotMockData from '../../../../../../components/d3-chart/__mocks__/scatterplot';
import VennMockData from '../../../../../../components/d3-chart/__mocks__/venn';
import FeedbackRatingFormExample
from '../../../../../ux-patterns/feedback-rating/docs/examples/feedback_rating_form.tsx';
import PrimaryTable from '../Tables/PrimaryTable';

export type DashboardProps = {
Expand Down Expand Up @@ -118,6 +120,9 @@ export function Dashboard({ showPrimaryTableFooter = false }: DashboardProps) {

return (
<Box style={{ background: 'var(--intergalactic-bg-secondary-neutral)' }}>
<Box my={4} w='100%'>
<FeedbackRatingFormExample />
</Box>
<Box pb={10} pt={2}>
<Flex direction='column' gap={2} my={4} mb={6}>
<Flex gap={2} flexWrap alignItems='center'>
Expand Down
27 changes: 10 additions & 17 deletions stories/patterns/core/tests/all-components/components/Tables/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import React from 'react';

import PrimaryTable from './PrimaryTable';
import { SecondaryTable } from './SecondaryTable';
import FeedbackRatingFormExample from '../../../../../../patterns/ux-patterns/feedback-rating/docs/examples/feedback_rating_form';

export type TablesProps = {
showPrimaryAndSecondary?: boolean;
Expand All @@ -20,22 +19,16 @@ export function Tables({ showPrimaryAndSecondary = true }: TablesProps) {
<PrimaryTable onPageErrorChange={setPageErrorActive} />

{!pageErrorActive && (
<>
<Box my={4} w='100%'>
<FeedbackRatingFormExample />
</Box>

<Flex my={4} gap={4}>
<Card w='100%'>
<Card.Header>
<Card.Title tag='h3'>Keywords</Card.Title>
</Card.Header>
<Card.Body p={0} pb={1}>
<SecondaryTable />
</Card.Body>
</Card>
</Flex>
</>
<Flex my={4} gap={4}>
<Card w='100%'>
<Card.Header>
<Card.Title tag='h3'>Keywords</Card.Title>
</Card.Header>
<Card.Body p={0} pb={1}>
<SecondaryTable />
</Card.Body>
</Card>
</Flex>
)}
</>
)}
Expand Down
Loading