Bump dependencies #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earmark 0.2.1 -> 1.3.1 ex_doc 0.11.5 -> 0.19.3 idna 5.1.0 -> 6.0.0 Judging by the idna changelog, there aren't any actual breaking changes in 6.0.0: https://github.com/benoitc/erlang-idna/blob/3eb54ccbfa6fb917c0f4ca9197da337ad888ffe0/CHANGELOG Turns out that idna 6.0.0 has some breaking changes so adjust how punycode conversions are done References: * benoitc/erlang-idna#28 * benoitc/erlang-idna#26 (comment)
Contributor
Author
|
Should probably test this new code with previous idna versions, but not sure if there's a way to do that in exunit. Maybe by specifying an extra mix.lock file for testing? |
Contributor
Author
|
@r3l4t1v you can just use my fork: https://github.com/axelson/publicsuffix-elixir Seomoz hasn't been responsive for quite a while. I may push my fork to hex at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
earmark 0.2.1 -> 1.3.1
ex_doc 0.11.5 -> 0.19.3
idna 5.1.0 -> 6.0.0
Judging by the idna changelog, there aren't any actual breaking changes
in 6.0.0:
https://github.com/benoitc/erlang-idna/blob/3eb54ccbfa6fb917c0f4ca9197da337ad888ffe0/CHANGELOG
Turns out that idna 6.0.0 has some breaking changes so adjust how
punycode conversions are done
References:
Note: the
test "compiles using a newly fetched copy of the rules file if so configured"seems to use a version ofpublicsuffix-elixirfrom thedepsdirectory so I couldn't get it to pass locally.