Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a gap in private certificate handling: when flag_use_private_cacert = true, the rootCA was not being imported into the JVM trust
stores of Java-based containers. As a result, any TLS connection made from within those containers to services secured by the same private CA would
fail. This PR closes that gap unconditionally for backend and cron, and extends it to wave-lite when that service is also enabled.
Changes by Condition
flag_use_private_cacert = true(all deployments)What changed:
the container JVM's cacerts, then execs the original container command
containers at /tmp/
leaf cert and key were copied)
Why: The JVM inside each container maintains its own trust store, independent of the host OS trust store. Even if update-ca-trust is run on the host,
Java processes inside containers will still reject TLS connections to private-CA-secured services unless the rootCA is explicitly imported into the
container JVM cacerts.
flag_use_private_cacert = trueANDflag_use_wave_lite = trueWhat changed:
below)
Why: Wave Lite is a Java service and has the same JVM trust store requirement as backend and cron.
flag_use_wave_lite = truewith private cert — Compute WorkersWhat changed:
compute workers
Why: Nextflow compute workers pull Wave-augmented container images from the Wave Lite server over HTTPS. Because Docker on the worker host (not inside
a container) is making that pull, there is no entrypoint wrapper that can help — the rootCA must be in the host OS trust store, which means it must
be baked into the AMI used by the Compute Environment.
Documentation only
distinction, and the Wave Lite addendum