Update default Nextflow version to 26.04 - #72
Conversation
Code ReviewThe change is minimal: updates the default Tests: N/A — this is a CI workflow config change only. Documentation/Examples: No updates needed for a version bump in a workflow file. UX: The old One observation: if |
Code ReviewThis PR updates the supported Nextflow version matrix from Findings1. The manual-dispatch default was updated to nextflow_version: ${{ github.event_name == 'workflow_dispatch' && fromJSON(format('["{0}"]', github.event.inputs.nextflow_version)) || fromJSON('["25.10"]') }}Automated post-CI runs will always test against 2. nextflowVersion = '24.10.0'
3. The repo maintains a Keep-a-Changelog |
|
test comment to verify posting works |
Code ReviewThis PR bumps the minimum supported Nextflow version from 25.04 to 25.10, adds 26.04 to the CI test matrix, and aligns docs and CI consistently. The changes are internally coherent — docs, CI, and the example workflow all agree on the new minimum. Findings1.
Should be updated to 2. The manual-dispatch path correctly offers both nextflow_version: ${{ ... || fromJSON('["25.10"]') }}Automated runs triggered by
|
1 similar comment
Code ReviewThis PR bumps the minimum supported Nextflow version from 25.04 to 25.10, adds 26.04 to the CI test matrix, and aligns docs and CI consistently. The changes are internally coherent — docs, CI, and the example workflow all agree on the new minimum. Findings1.
Should be updated to 2. The manual-dispatch path correctly offers both nextflow_version: ${{ ... || fromJSON('["25.10"]') }}Automated runs triggered by
|
Update AGENTS.md matrix, example workflow auto-trigger fallback, plugin manifest minimum version, and CHANGELOG. Generated by Codex Co-authored-by: Cursor <cursoragent@cursor.com>
Code ReviewThis PR bumps the minimum supported Nextflow version to 25.10.0 and shifts the CI matrix to test 25.10/26.04, removing 25.04 coverage. All 7 changed files are internally consistent, and a CHANGELOG entry is present. Findings
The
The previous SummaryClean version bump with consistent updates across docs, CI, and the build manifest. The only actionable suggestion is reordering the |
|
Addressed Claude review in 98c2d7c:
NF 26.04 compatibility validated via CI matrix on this PR (all checks green). |
Code ReviewThis PR bumps the minimum supported Nextflow version to 25.10.0 and updates the CI matrix to test against 25.10 and 26.04. Documentation, CHANGELOG, AGENTS.md, and workflow files are all updated consistently — good coverage overall. Two things worth addressing: build.gradle / docs inconsistency not acknowledged in changelog The diff shows build.gradle changing from nextflowVersion = '24.10.0' to '25.10.0', but the docs being updated from 25.04.0 to 25.10.0. Before this PR, the enforced minimum (build.gradle) and the documented minimum (docs) were different. The CHANGELOG entry says 'Raised minimum supported Nextflow version to 25.10.0' without noting that the actual prior floor was 24.10.0 in practice. Users on 24.10.x-25.04.x could previously use the plugin despite the docs saying otherwise. Worth clarifying whether 25.10.0 is a breaking change relative to what was actually enforced. example.yml: default option listed second in dropdown The options list in example.yml has '25.10' first and '26.04' second, but the default is '26.04'. GitHub Actions renders options in declaration order, so '25.10' appears at the top of the dropdown while '26.04' is pre-selected. Convention is to put the default first to avoid confusion for manual dispatches. Consider swapping the order. |
This pull request updates the minimum required Nextflow version across documentation and CI workflows to ensure consistency and support for newer features. The changes also update the default and available Nextflow versions in workflow configuration files.
CI and workflow configuration updates:
.github/workflows/ci.ymlto test against versions25.10and26.04, removing25.04from the matrix..github/workflows/example.ymlto26.04and added26.04to the list of selectable options.Documentation updates:
docs/CONTRIBUTING.mdanddocs/getting-started/setup.mdfrom25.04.0to25.10.0to reflect the new baseline. [1] [2]