Add support for gradient roles #3426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
arqunis
added
enhancement
arqunis
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
One unresolved question is if
RoleColoursshould be Copy or not.
I think it is fine for it to be Copy. It doesn't appear to be a structure that they are going to be updating frequently, so we shouldn't have to worry about them introducing a heavy type into it, and the overall size turns out to be 20 bytes, which is dirt cheap to copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting out from #3382 to rebase and fix it up. One unresolved question is if
RoleColoursshould beCopyor not.