Fix PowerPoint relationship copying edge cases - #312
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the slide publishing/copy pipeline against several PowerPoint package/relationship edge cases that can lead to stale references or repair prompts when opening generated decks.
Changes:
- Rewrites
a1611:picAttrSrcUrlonline-image relationship IDs during content part copying. - Skips copying zero-byte
CustomXmlParts referenced byp:custDataand prunes danglingp:custDataLstmarkup. - Normalizes non-standard SVG MIME type
image/svgtoimage/svg+xmlduring image part copy, and bumps CLI changelog to 0.1.2.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Clippit/PtOpenXmlUtil.cs | Adds A1611.picAttrSrcUrl XName constant used for relationship rewrite detection. |
| Clippit/PowerPoint/Fluent/FluentPresentationBuilder.Copy.cs | Implements the relationship rewrite + empty customXml pruning + SVG content-type normalization. |
| Clippit.Tests/PowerPoint/PresentationBuilderSlidePublishingTests.Fluent.cs | Adds a regression test for skipping empty CustomXmlPart referenced by p:custData. |
| Clippit.Cli/CHANGELOG.md | Adds 0.1.2 changelog entry for the upcoming CLI publish. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sergey-tihon
added a commit
that referenced
this pull request
Jun 3, 2026
* docs: add v3.4.5 changelog entry Summarises all changes on master since the v3.4.4 tag: CLI feature (#309), pptx relationship fix (#312), refactors (#307/#308), test and dependency updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: update notes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sergey-tihon
added a commit
that referenced
this pull request
Jun 29, 2026
* feat: support online images * fix: avoid PowerPoint repair on generated decks * fix: address PR review comments * fix: preserve corrupt customXml handling * fix: stream customXml copy after empty check * refactor: simplify customXml pruning flow
sergey-tihon
added a commit
that referenced
this pull request
Jun 29, 2026
* docs: add v3.4.5 changelog entry Summarises all changes on master since the v3.4.4 tag: CLI feature (#309), pptx relationship fix (#312), refactors (#307/#308), test and dependency updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: update notes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed Issues
Validation