Skip to content

Report the number of escape characters formatted into themed sequence rendering #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2025
Merged

Report the number of escape characters formatted into themed sequence rendering #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcecc68
Report the number of escape characters formatted into themed sequence…
nblumhardt Jan 13, 2023
bf45645
Merge branch 'dev' into fix-sequence-width-reporting
nblumhardt Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Serilog.Sinks.Console/Sinks/SystemConsole/Formatting/ThemedJsonValueFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ protected override int VisitSequenceValue(ThemedValueFormatterState state, Seque
}

delim = ", ";
Visit(state.Nest(), sequence.Elements[index]);
count += Visit(state.Nest(), sequence.Elements[index]);
}

using (ApplyStyle(state.Output, ConsoleThemeStyle.TertiaryText, ref count))
Expand Down
36 changes: 18 additions & 18 deletions src/Serilog.Sinks.Console/Sinks/SystemConsole/Output/ExceptionTokenRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,27 +25,27 @@ class ExceptionTokenRenderer : OutputTemplateTokenRenderer

readonly ConsoleTheme _theme;

public ExceptionTokenRenderer(ConsoleTheme theme, PropertyToken pt)
public ExceptionTokenRenderer(ConsoleTheme theme)
{
_theme = theme;
}
_theme = theme;
}

public override void Render(LogEvent logEvent, TextWriter output)
{
// Padding is never applied by this renderer.

if (logEvent.Exception is null)
return;

var lines = new StringReader(logEvent.Exception.ToString());
string? nextLine;
while ((nextLine = lines.ReadLine()) != null)
{
var style = nextLine.StartsWith(StackFrameLinePrefix) ? ConsoleThemeStyle.SecondaryText : ConsoleThemeStyle.Text;
var _ = 0;
using (_theme.Apply(output, style, ref _))
output.Write(nextLine);
output.WriteLine();
}
// Padding is never applied by this renderer.

if (logEvent.Exception is null)
return;

var lines = new StringReader(logEvent.Exception.ToString());
string? nextLine;
while ((nextLine = lines.ReadLine()) != null)
{
var style = nextLine.StartsWith(StackFrameLinePrefix) ? ConsoleThemeStyle.SecondaryText : ConsoleThemeStyle.Text;
var _ = 0;
using (_theme.Apply(output, style, ref _))
output.Write(nextLine);
output.WriteLine();
}
}
}
2 changes: 1 addition & 1 deletion src/Serilog.Sinks.Console/Sinks/SystemConsole/Output/OutputTemplateRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public OutputTemplateRenderer(ConsoleTheme theme, string outputTemplate, IFormat
}
else if (pt.PropertyName == OutputProperties.ExceptionPropertyName)
{
renderers.Add(new ExceptionTokenRenderer(theme, pt));
renderers.Add(new ExceptionTokenRenderer(theme));
}
else if (pt.PropertyName == OutputProperties.MessagePropertyName)
{
Expand Down