Skip to content

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Mar 18, 2025

What type of PR is this?

Bug

What this PR does / why we need it?

Fix some bug of flowcontrol plugin

Which issue(s) this PR fixes?

Fixes #1759

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../flowcontrol/AbstractXdsHttpClientInterceptor.java 0.00% 4 Missing ⚠️
...mant/flowcontrol/DispatcherServletInterceptor.java 0.00% 1 Missing ⚠️
...lowcontrol/retry/client/OkHttp3ClientDeclarer.java 0.00% 1 Missing ⚠️
...y/client/OkHttpClientInterceptorChainDeclarer.java 0.00% 1 Missing ⚠️
Flag Coverage Δ Complexity Δ
unittests 28.08% <0.00%> (+0.41%) 304.00 <0.00> (+142.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...mant/flowcontrol/DispatcherServletInterceptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lowcontrol/retry/client/OkHttp3ClientDeclarer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...y/client/OkHttpClientInterceptorChainDeclarer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../flowcontrol/AbstractXdsHttpClientInterceptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hanbingleixue hanbingleixue changed the title Fix some bug of flowcontrol plugin Fix the problem of flowcontrol plugin interceptor declaration error and failure to remove retried instances Mar 21, 2025
provenceee
provenceee previously approved these changes Mar 26, 2025
@lilai23
Copy link
Collaborator

lilai23 commented Mar 29, 2025

action for xds not executed

.setApiPath(getRequestUri.apply(request))
.setHeaders(getHeaders(request))
.setMethod(getMethod.apply(request))
.setServiceName(getHeader.apply(request, ConfigConst.FLOW_REMOTE_SERVICE_NAME_HEADER_KEY))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the problem of flowcontrol plugin interceptor declaration error and failure to remove retried instances
3 participants