feat(dynamic config): implement apollo dynamic config crud methods #1808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaaandychen
force-pushed
the
apollo-dynamic-config
branch
3 times, most recently
from
d1bf2ba to
1b14006
Compare
lilai23
reviewed
Sep 15, 2025
| @@ -0,0 +1,54 @@ | |||
| package io.sermant.implement.service.dynamicconfig.apollo.config; | |||
There was a problem hiding this comment.
add copyright for any new files
lilai23
reviewed
Sep 15, 2025
Comment on lines
43
to
67
| if ("app.id".equals(name)) { | ||
| val = getAppId(); | ||
| return StringUtils.isNoneBlank(val) ? val : defaultValue; | ||
| } else if ("apollo.access-key.secret".equals(name)) { | ||
| val = getAccessKeySecret(); | ||
| return StringUtils.isNoneBlank(val) ? val : defaultValue; |
There was a problem hiding this comment.
constant string can be extracted
lilai23
reviewed
Sep 15, 2025
Comment on lines
33
to
52
| if ("apollo.cluster".equals(name)) { | ||
| String c = ApolloProperty.getCluster(); |
lilai23
reviewed
Sep 15, 2025
| * @since 2025/8/7 | ||
| */ | ||
| public class ApolloBufferedClient implements Closeable { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(ApolloBufferedClient.class.getName()); |
There was a problem hiding this comment.
use java util logging logger
lilai23
reviewed
Sep 15, 2025
| } catch (ApolloOpenApiException e) { | ||
| if (e.getCause() instanceof ApolloOpenApiException) { | ||
| ApolloOpenApiException apolloException = (ApolloOpenApiException) e.getCause(); | ||
| if (apolloException.getStatus() == 400 || apolloException.getStatus() == 409) { |
There was a problem hiding this comment.
define error code or use exists constant code
lilai23
reviewed
Sep 15, 2025
| connection.setReadTimeout(ApolloProperty.getReadTimeout()); | ||
|
|
||
| int responseCode = connection.getResponseCode(); | ||
| return responseCode >= 200 && responseCode < 300; |
There was a problem hiding this comment.
define response code or use exists constant code
lilai23
reviewed
Sep 15, 2025
|
|
||
| private final ServiceMeta serviceMeta; | ||
|
|
||
| private final Map<String, List<ConfigChangeListener>> groupListeners = new HashMap<>(); |
There was a problem hiding this comment.
use ConcurrentHashMap to avoid multi thread problems
lilai23
reviewed
Sep 15, 2025
Comment on lines
+38
to
+65
| public ApolloDynamicConfigService() { | ||
| serviceMeta = ConfigManager.getConfig(ServiceMeta.class); | ||
| } |
There was a problem hiding this comment.
you can add success logs for operations in methods below
lilai23
reviewed
Sep 15, 2025
Comment on lines
+20
to
+44
| /** | ||
| * Check whether the group name is valid | ||
| * 1. supports only English and digit characters and three special symbols ('.','-','_') | ||
| * 2. not supports single "." or "/", and it cannot end with ".json", ".yml", ".yaml", | ||
| * ".xml", or ".properties". | ||
| * | ||
| * @param namespace group name | ||
| * @return true: valid; false: invalid |
There was a problem hiding this comment.
remember introduce rules in docs on Sermant website
aaaandychen
force-pushed
the
apollo-dynamic-config
branch
from
1b14006 to
f6f1471
Compare
Signed-off-by: chenzhenyang <[email protected]>
aaaandychen
force-pushed
the
apollo-dynamic-config
branch
from
f6f1471 to
269b8c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support ApolloDynamicConfigService and implement CRUD operations for configs
What type of PR is this?
Feature
What this PR does / why we need it?
Describe it.
Which issue(s) this PR fixes？
Fixes #1806
Does this PR introduce a user-facing change?
No
Checklist