Skip to content

Add deprecation notice to README.md#21

Merged
gaffneyc merged 1 commit into
masterfrom
deprecate
Aug 7, 2019
Merged

Add deprecation notice to README.md#21
gaffneyc merged 1 commit into
masterfrom
deprecate

Conversation

@gaffneyc

@gaffneyc gaffneyc commented Aug 6, 2019

Copy link
Copy Markdown
Collaborator

It has been a few years since the last update and jemalloc has had
several releases in that time. I've been maintaining my fork and
provided support on it for a couple years now and I think it's time to
deprecate this one.

This buildpack has had a great life (and should continue to work as is)
but I think it's worth it to steer folks toward a maintained fork. For
example, it was recommended for Ruby to skip the 4.x branch and to stick
to 3.6.0 (released in 2015), but our team has had really good luck with
5.1.0 and 5.2.0.

There was a pull request to merge the fork into the buildpack
but given the risk it would expose anyone using the current
buildpack to I don't think it is a good path forward. For more
details see this comment: #18 (comment)

@mojodna @nateberkopec thoughts?

It has been a few years since the last update and jemalloc has had
several releases in that time. I've been maintaining my fork and
provided support on it for a couple years now and I think it's time to
deprecate this one.

This buildpack has had a great life (and should continue to work as is)
but I think it's worth it to steer folks toward a maintained fork. For
example, it was recommended for Ruby to skip the 4.x branch and to stick
to 3.6.0 (released in 2015), but our team has had really good luck with
5.1.0 and 5.2.0.

There was a [pull request](#18)
to merge the fork into the buildpack but given the risk it would expose
anyone using the current buildpack to I don't think it is a good path
forward. For more details see this comment:
#18 (comment)
@nateberkopec

Copy link
Copy Markdown
Collaborator

Cheers! Maintained is better than not!

I agree that leaving this as a "historical artifact" for current users that don't want to upgrade is preferable to merging.

@sethfitz

sethfitz commented Aug 7, 2019

Copy link
Copy Markdown
Owner

👍 to that!

@gaffneyc gaffneyc merged commit 43bef0c into master Aug 7, 2019
@gaffneyc gaffneyc deleted the deprecate branch August 7, 2019 19:56
@gaffneyc

gaffneyc commented Aug 7, 2019

Copy link
Copy Markdown
Collaborator Author

🎉 Thanks guys

@sethfitz

sethfitz commented Aug 7, 2019

Copy link
Copy Markdown
Owner

Thank you for continuing to maintain a jemalloc buildpack!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants