Add support for argon2d and argon2i variants #2416
Conversation
|
I am unsure what's causing the failures in the CI tests. They all appear to be a failing |
|
most likely they're flakes |
|
Any thoughts on these additions? This PR is a dependency to add argon2d/2i support to the Python cryptography project |
openssl/src/kdf.rs
Outdated
| #[allow(clippy::too_many_arguments)] | ||
| pub fn argon2id( | ||
| fn argon2_helper( | ||
| kdf_identifier: &'static [u8], |
There was a problem hiding this comment.
for soundness this needs to be a &CStr or something, otherwise you get buffer overread if you pass something without a trailing nul
There was a problem hiding this comment.
Done @alex appreciate the review!
There was a problem hiding this comment.
The c"" syntax is not compatible with our MSRV
There was a problem hiding this comment.
Ahh, apologies - updated to use (the ugly) CStr::from_bytes_with_nul
Expose functionality of supplementary variants, Argon2d and Argon2i, as described in RFC 9106