adding triangulation and tetrahedralization functions#118
Closed
adding triangulation and tetrahedralization functions#118
Conversation
Owner
|
There seems to already exist a great python wrapper for tetgen, with a good API that is similar to ours. So I personally do not think the damage of polluting the license is offset by any gain of having it wrapped in our library, at least right now. So I propose we excise the tetrahedralization from this PR. On triangulation, I am happy to learn about this library! Seems to do what I use triangle for, but better. Happy to both merge now, and merge once their refinement PR is merged. Up to you. |
Collaborator
Author
|
Your point makes sense to me. Let's leave off this pull request for now, and revisit it when the triangulation library is more mature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds triangulation and tetrahedralization capacity.
For triangulation, this uses CDT. This is, in my opinion, better than Shewchuck's classic Triangle for 3 reasons:
For tetrahedralization, this uses TetGen through its libigl wrapper.
It's still not quite ready to merge before we discuss 2 important points: