Fix Shakapacker configuration warnings

[justin808]

Summary

• Remove unused babel.config.js (ignored when using SWC transpiler)
• Add missing bin/export-bundler-config binstub
• Update existing shakapacker binstubs to latest version

Warnings Addressed

This PR fixes warnings from Shakapacker's configuration validator:

Fixed:

• Warning: Babel configuration files found but javascript_transpiler is 'swc'
• Warning: Missing binstubs (bin/export-bundler-config)

Not Addressed (requires separate dependency changes):

• Warning: swc-loader is not needed with Rspack (requires package.json changes)
• Info: Version mismatch (expected in local development)

Test Plan

• Run bin/rails shakapacker:binstubs successfully
• Tests pass
• No RuboCop violations in changed files
• Verify binstubs are executable

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Added a CLI utility to export the demo’s bundler configuration, supporting arguments and proper exit codes.

• Chores

  • Removed the custom Babel configuration from the demo to rely on sensible defaults.
  • Cleaned up magic comments in development and runner scripts with no behavior changes.

[coderabbitai]

Walkthrough

Removes the Babel config from demos/basic-v16-rspack, adds a Node.js shim script to export bundler config, and updates two Ruby bin scripts by deleting the frozen_string_literal magic comment. No public API changes are declared.

Changes

Cohort / File(s)	Change Summary
Babel config removal demos/basic-v16-rspack/babel.config.js	Deleted prior Babel config that extended shakapacker presets, environment conditionals, React preset/options, HMR plugin, and production PropTypes removal.
Bundler config exporter shim demos/basic-v16-rspack/bin/export-bundler-config	Added Node.js script that imports run from shakapacker/configExporter, forwards CLI args, exits with provided code on success, logs error and exits 1 on failure.
Ruby bin script header cleanup demos/basic-v16-rspack/bin/shakapacker, demos/basic-v16-rspack/bin/shakapacker-dev-server	Removed # frozen_string_literal: true header. No functional code changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Script as export-bundler-config
  participant Exporter as shakapacker/configExporter.run
  User->>Script: invoke with CLI args
  Script->>Exporter: run(args)
  alt success
    Exporter-->>Script: Promise resolved with exitCode
    Script->>Script: process.exit(exitCode)
  else failure
    Exporter-->>Script: Promise rejected (error)
    Script->>User: print error.message
    Script->>Script: process.exit(1)
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibbled wires, tidy and slick,
Swept Babel’s burrow—gone in a flick.
A shim now hops to export and go,
While Ruby sheds its icy snow.
Ears up, configs light, paths clear—
Thump-thump: release draws near! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly summarizes the primary change of resolving Shakapacker configuration warnings by grouping related updates under a concise description.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch justin808/fix-shakapacker-warnings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[claude]

Code Review Summary

Overall, this is a well-executed cleanup PR that properly addresses Shakapacker configuration warnings. The changes are correct and aligned with the project's migration to Rspack with SWC transpiler.

---

✅ Strengths

1. Correct Configuration Cleanup

• ✅ Removed unused babel.config.js: Since the project uses javascript_transpiler: 'swc' (config/shakapacker.yml:43), Babel configuration is not needed and was correctly removed
• ✅ Added missing binstub: The bin/export-bundler-config binstub is properly implemented and executable (permissions verified)
• ✅ Updated binstubs to latest format: Removed frozen_string_literal comments from Ruby binstubs aligns with current Shakapacker conventions

2. Code Quality

• ✅ Clean implementation: The new bin/export-bundler-config follows the standard Shakapacker binstub pattern
• ✅ Proper error handling: Includes try-catch with process exit codes
• ✅ Executable permissions: File has correct 755 permissions
• ✅ Consistent style: Matches other binstubs in the project

3. Documentation & Testing

• ✅ Clear PR description: Well-documented rationale and test plan
• ✅ Test plan completed: Author verified all items including binstub execution, tests, and RuboCop
• ✅ Proper scoping: Correctly identifies remaining warnings as out of scope (swc-loader, version mismatch)

---

🔍 Analysis by Category

Code Quality & Best Practices ⭐⭐⭐⭐⭐

• Follows Shakapacker conventions
• Consistent with repository standards (CONTRIBUTING.md)
• No code smells or anti-patterns

Potential Bugs or Issues ⭐⭐⭐⭐⭐

• No bugs identified
• Changes are purely additive/removal of unused code
• The removed Babel config contained React-specific configuration, but since SWC is now handling transpilation, this is correctly removed

Performance Considerations ⭐⭐⭐⭐⭐

• Positive impact: Removing unused Babel config eliminates confusion and potential misconfiguration
• Neutral: The new binstub is a thin wrapper with no performance implications
• SWC transpiler (already in use) is faster than Babel

Security Concerns ⭐⭐⭐⭐⭐

• No security issues
• No introduction of dependencies or external code execution
• Standard binstub pattern from upstream Shakapacker

Test Coverage ⭐⭐⭐⭐

• No dedicated tests for binstubs (common practice for generated scripts)
• Author verified manual testing in test plan
• Note: The demo doesn't appear to have a test suite in the traditional sense (no spec/ or test/ directories found), which is acceptable for a demo project

---

💡 Minor Suggestions (Optional)

1. Consider documenting the transpiler choice: Since removing Babel is significant, you might add a comment in shakapacker.yml or the demo's README explaining why SWC is used over Babel for this demo

   # SWC provides faster transpilation and better Rspack integration
   javascript_transpiler: 'swc'

2. Future consideration: The PR notes that swc-loader warning remains. When addressing that in a future PR, ensure to test that SWC transpilation still works without the explicit loader dependency.

---

📊 Final Assessment

Category	Rating	Notes
Code Quality	⭐⭐⭐⭐⭐	Excellent - follows all conventions
Correctness	⭐⭐⭐⭐⭐	Changes are accurate and appropriate
Testing	⭐⭐⭐⭐	Manual testing completed, adequate for demo
Documentation	⭐⭐⭐⭐⭐	Clear PR description and test plan
Overall	⭐⭐⭐⭐⭐	LGTM - Ready to merge

---

✅ Recommendation

APPROVE - This PR is production-ready and should be merged. It correctly addresses the stated warnings, follows project conventions, and includes no risky changes.

The changes are:

• Safe: Only removing unused config and adding standard binstub
• Tested: Author completed comprehensive test plan
• Well-documented: Clear rationale and scope
• Aligned: Consistent with Rspack + SWC migration strategy

Great work on the cleanup! 🎉

---

Review generated with Claude Code

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

demos/basic-v16-rspack/bin/export-bundler-config (1)

6-11: Consider more robust error handling.

The current error handling assumes error.message exists. For better reliability, consider handling cases where the error might not be an Error object.

 run(process.argv.slice(2))
   .then((exitCode) => process.exit(exitCode))
   .catch((error) => {
-    console.error(error.message)
+    console.error(error?.message || error || 'Unknown error')
     process.exit(1)
   })

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0bfb7be and f42dd64.

📒 Files selected for processing (4)

• demos/basic-v16-rspack/babel.config.js (0 hunks)
• demos/basic-v16-rspack/bin/export-bundler-config (1 hunks)
• demos/basic-v16-rspack/bin/shakapacker (0 hunks)
• demos/basic-v16-rspack/bin/shakapacker-dev-server (0 hunks)

💤 Files with no reviewable changes (3)

• demos/basic-v16-rspack/babel.config.js
• demos/basic-v16-rspack/bin/shakapacker-dev-server
• demos/basic-v16-rspack/bin/shakapacker

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: claude-review

🔇 Additional comments (1)

demos/basic-v16-rspack/bin/export-bundler-config (1)

4-4: Module exists via declared dependency
The shakapacker package is listed at ^9.0.0 in package.json, so require('shakapacker/configExporter') will resolve correctly.