Fix LibraryThing false negatives with Cloudflare bypass#2810
Open
jake112-AO wants to merge 3 commits intosherlock-project:masterfrom
Open
Fix LibraryThing false negatives with Cloudflare bypass#2810jake112-AO wants to merge 3 commits intosherlock-project:masterfrom
jake112-AO wants to merge 3 commits intosherlock-project:masterfrom
Conversation
Contributor
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LibraryThing was returning false negatives (failing to find existing users) because the site uses Cloudflare bot protection that blocks standard HTTP requests.
Testing
FlorenceArt- Now correctly detectedasdkjfhakjsdhf123456789- Correctly returns "not found"Solution
cloudscraperlibrary to bypass Cloudflare challengesuseCloudScraperflag in site configurationChanges
sherlock_project/sherlock.py: Added cloudscraper import and conditional session creationsherlock_project/resources/data.json: Added"useCloudScraper": trueto LibraryThingpyproject.toml: Added cloudscraper dependencyNotes
"useCloudScraper": truewill use cloudscraper