Fix UnicodeDecodeError crash when handling redirects with non-UTF-8 encoding#2822
Open
04cb wants to merge 1 commit intosherlock-project:masterfrom
Open
Fix UnicodeDecodeError crash when handling redirects with non-UTF-8 encoding#282204cb wants to merge 1 commit intosherlock-project:masterfrom
04cb wants to merge 1 commit intosherlock-project:masterfrom
Conversation
diamondoke
approved these changes
Mar 7, 2026
diamondoke
approved these changes
Mar 7, 2026
Frosmin
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2730. When scanning usernames with special characters, some servers send redirect URLs with non-UTF-8 encoding. The requests library raises UnicodeDecodeError during redirect handling, which was not caught by the existing exception handlers. Added a specific handler for UnicodeDecodeError to treat it as a connection error, allowing the scan to continue gracefully.