fix: autocomplete quickview alignment - #5006
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR updates component styling in the entity reference and quick view modules. Button box padding is standardized to include horizontal spacing, and form label styles are refined to improve text wrapping and overflow behavior through adjusted height, whitespace, and word-break rules. ChangesComponent Styling Improvements
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 OpenGrep (1.22.0)OpenGrep fatal error (exit code 2): [00.13][ERROR]: Error: exception Unix_error: No such file or directory stat shesha-reactjs/src/components/quickView/styles/styles.ts Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shesha-reactjs/src/components/quickView/styles/styles.ts`:
- Around line 59-73: Replace the overly broad `.read-only-display-form-item *`
rule that uses multiple `!important` declarations with a narrowly scoped
selector that targets only the actual text/content container(s) (for example
direct children or the wrapper with `[data-tag-wrapper="true"]`) so internal
components like ReflistTag/Tooltip/Tag/ShaIcon are not affected; increase
selector specificity as needed instead of using `!important` and restore/retain
the intended ReadOnlyDisplayFormItem base styles (`overflow: hidden`,
`text-overflow: ellipsis`, `white-space: nowrap`) for non-expanded content by
applying the new selector to the textual element(s) only.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 7c398833-5fd9-48cf-a1a2-1391a6126bfd
⛔ Files ignored due to path filters (1)
shesha-reactjs/package-lock.jsonis excluded by!**/package-lock.jsonand included by none
📒 Files selected for processing (2)
shesha-reactjs/src/components/entityReference/styles/styles.tsshesha-reactjs/src/components/quickView/styles/styles.ts
Summary by CodeRabbit