Skip to content

fix table add row height - #5143

Open
James-Baloyi wants to merge 1 commit into
shesha-io:mainfrom
James-Baloyi:james/b/table-inline-add-row-height
Open

fix table add row height#5143
James-Baloyi wants to merge 1 commit into
shesha-io:mainfrom
James-Baloyi:james/b/table-inline-add-row-height

Conversation

@James-Baloyi

@James-Baloyi James-Baloyi commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved row sizing in the table so new rows now adapt more naturally to the configured height instead of stretching unexpectedly.
    • Updated the action cell layout to use a more consistent automatic height, helping keep row content aligned and visually stable.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 72ec45aa-882f-4c9b-aead-66fec7ae263b

📥 Commits

Reviewing files that changed from the base of the PR and between 98d0837 and 0bc2587.

📒 Files selected for processing (2)
  • shesha-reactjs/src/components/reactTable/newRowCell.tsx
  • shesha-reactjs/src/components/reactTable/styles/styles.ts
💤 Files with no reviewable changes (1)
  • shesha-reactjs/src/components/reactTable/newRowCell.tsx

Walkthrough

Removes a hardcoded WebKit-specific height: -webkit-fill-available !important style from the new row cell's inline style and from the shaNewRow/shaCrudCell CSS, replacing it with a rowHeight-conditional height or auto.

Changes

Row Height Styling

Layer / File(s) Summary
Row height styling update
shesha-reactjs/src/components/reactTable/newRowCell.tsx, shesha-reactjs/src/components/reactTable/styles/styles.ts
Removes the WebKit fill-available height override from the new row cell's inline style, and updates shaNewRow/shaCrudCell CSS to use a rowHeight-driven height or auto instead.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

A rabbit hops through styles anew,
No more fill-available glue,
Auto height, or rowHeight's call,
The row now fits it, big or small,
Hop hop, CSS refined for all! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately reflects the main change: adding or adjusting row height behavior in the table.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant