Support for a separate configuration file #49
Open
ivanlisovyi wants to merge 2 commits intoshibapm:masterfrom
Open
Support for a separate configuration file #49ivanlisovyi wants to merge 2 commits intoshibapm:masterfrom
ivanlisovyi wants to merge 2 commits intoshibapm:masterfrom
Conversation
Member
|
Oops, I missed this - sorry. I'm open to the idea, but I'd rather not gain another dependency to pay for it - if the config was JSON 👍🏻. WRT adding tests, I'm open to those changes too 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR adds support for a separate config file that could be used instead of
Package.swiftto configure thekomondorgit hooks. The separate config file is a viable choice when you wannakomondorwith something like Mint or other similar tools.By default,
komondoris going to usePackage.swiftto configure hooks and when--use-config-fileflag is being usedkomondorgonna try to usekomondor.ymlfile from the project root folder.--use-config-fileflag is supported byinstallandruncommands.Examples
With install command
With run command
Additional Notes
komondorsource code needs to be moved to a separate target. I think this kind of change is a little bit out of the scope of this PR. It shall be relatively straightforward to extract the source code into a separate target (e.g.KomondorCoreorKomondorFramework) and shall be probably done in a separate PR (I will be glad to do that in a follow-up PR).