Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r0,r1,r2 に対応するコーデックを
a=rid:の pt= に基づいて生成するようにしました。pt= が無い場合、最初に見つかった
a=rtpmap:のコーデックを利用します(既存の動作と同じ)。This pull request includes several changes to the
examples/sumomofiles, focusing on improving the handling of optional parameters and updating the RTP (Real-time Transport Protocol) handling. It also includes updates to theCHANGES.mdfile and several changes to theproto/soracp.proto,include/sorac/, andsrc/directories.Updates to optional parameters handling:
examples/sumomo/option.c: Added handling forvideoandaudiooptions in thelong_opts[]struct and in thesumomo_option_parsefunction. Also, aSET_OPTBOOLmacro was introduced to simplify setting boolean options. [1] [2] [3] [4] [5]examples/sumomo/option.h: Addedvideoandaudiooptions to theSumomoOptionstruct.examples/sumomo/sumomo.c: Updated themainfunction to setvideoandaudiooptions based on the parsed options.Updates to RTP handling:
examples/sumomo/sumomo.c: Replacedrtp_encoding_parameterswithrtp_parametersin theStatestruct and updated theon_capture_framefunction to usertp_parameters. [1] [2] [3]examples/sumomo/util.cppandexamples/sumomo/util.h: Updated thesumomo_util_scale_simulcastfunction to take ascalesarray instead of anum_ridsinteger. [1] [2]include/sorac/signaling.hpp: Updated theGetRtpParametersmethod in theSignalingclass.proto/soracp.proto: Updated theRtpEncodingParametersmessage and added theRtpParametersmessage. [1] [2]src/signaling.cpp: Updated theGetRtpParametersmethod and the handling of RTP parameters in theSignalingImplclass. [1] [2] [3]Other changes:
CHANGES.md: Added entries for supporting multi-codec simulcast transmission and updatingprotoc-gen-jsonifto support optional parameters.