feat(hsbc-uk): Add credit card support by prisonblues · Pull Request #17 · shuckster/OBIS

prisonblues · 2026-01-12T01:51:28Z

Summary

Add credit card transaction export support (identifies CC accounts by normalisedProductCategoryCode === 'CC')
Add credit card PDF statement download feature with "CC PDFs" button
Downloads all CC statement PDFs going back to 2020 (since transaction API only has 18-month rolling window)

Changes

CC Transaction Support

Extract CC accounts from accounts API
Fetch transactions using identifierType=CARD endpoint
Handle both BILLED and UN_BILLED transaction types
Parse CC-specific fields (transactionCreditDebitCode)

CC PDF Downloads

New "CC PDFs" button (only shown when CC accounts exist)
Downloads PDFs individually with 5-second rate limiting to avoid API throttling
Handles both raw PDF and base64-encoded responses
Saves each PDF immediately as fetched
Filename format: CC_Statement_XXXX_YYYY-MM-DD.pdf

Test plan

Log into HSBC online banking with a credit card account
Load OBIS bookmarklet
Verify CC account appears in account list
Click "Fetch" and verify CC transactions are retrieved
Download all and verify CC transactions appear in CSV/OFX output
Click "CC PDFs" and verify PDF statements download

🤖 Generated with Claude Code

- Detect CC accounts via normalisedProductCategoryCode - Add fetchCreditCardTransactions with BILLED/UN_BILLED support - Fix pagination using json.pagination.nextPageIndex - Combine UN_BILLED and BILLED into single synthetic statement - Handle CC account display (masked card number)

Add ability to download all credit card PDF statements going back to 2020. - New "CC PDFs" button appears when CC accounts are detected - Downloads PDFs individually with 5-second rate limiting - Handles both raw PDF and base64-encoded responses - Saves each PDF immediately as fetched (no batching) - Filename format: CC_Statement_XXXX_YYYY-MM-DD.pdf Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Copilot

Pull request overview

Adds HSBC UK credit card support to OBIS by detecting CC accounts, fetching CC transactions via the CARD transactions endpoint, and enabling bulk download of CC statement PDFs from the statements service.

Changes:

Identify CC accounts via normalisedProductCategoryCode === 'CC' and surface them through the store/UI.
Fetch CC transactions (both UN_BILLED and BILLED) using a new CC transactions URL builder and fetcher.
Add a “CC PDFs” UI action that downloads statement PDFs (handling raw PDF vs base64 data URL responses).

Reviewed changes

Copilot reviewed 10 out of 18 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/ui/index.js	Wires new `DOWNLOAD_CC_PDFS` UI action to PDF download handler.
src/ui/components/obis-overlay-widget/YearsAndActionButtons.jsx	Adds conditional “CC PDFs” button when CC accounts exist.
src/ui/components/app.jsx	Passes new CC PDF download handler down to the overlay widget.
src/common/obis/actions.js	Introduces `DOWNLOAD_CC_PDFS` / `DOWNLOADED_CC_PDFS` action constants.
src/common/obis/zip.js	Adds `makePdfZip()` flow to save CC PDFs individually using a plugin-registered fetcher.
src/plugins/hsbc-uk/urls.js	Adds URL builders for CC transactions and statement PDF download.
src/plugins/hsbc-uk/api/accounts.js	Extends accounts parsing to include `availableBalance` and `normalisedProductCategoryCode`.
src/plugins/hsbc-uk/api/transactions.js	Adds CC transaction fetcher with pagination and CC-specific parsing.
src/plugins/hsbc-uk/api/statements.js	Adds statement PDF download + a loop to fetch all CC PDFs with rate limiting.
src/plugins/hsbc-uk/plugin.js	Integrates CC account detection, synthetic CC “statement”, CC transaction fetching, and registers CC PDF fetcher on `obis`.
dist/extension/ui.css	Rebuilt asset output.
dist/extension/statement.css	Rebuilt asset output.
dist/extension/obis-hsbc-uk.js	Rebuilt bundled extension output reflecting source changes.
dist/bookmarklet/ui.js	Rebuilt bookmarklet UI bundle reflecting source changes.
dist/bookmarklet/main.js	Rebuilt bookmarklet main bundle reflecting source changes.
dist/bookmarklet/ui.css	Rebuilt asset output.
dist/bookmarklet/statement.css	Rebuilt asset output.
dist/bookmarklet/plugins/hsbc-uk.js	Rebuilt bundled plugin output reflecting source changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-07T21:43:22Z

src/common/obis/zip.js

+/* globals obis, store */

 import { makePromise } from '@/cjs/promises'
 import { getGenerators } from '@/obis/generators'
 import { dateTimeString, zeroPad } from '@/obis/utils/dates'
 import { compatMakeStatements } from '@/obis/statements'


This module uses store() as a global (/* globals ... store */) rather than importing it (e.g. import { store } from '@/obis/store' as done in src/common/obis/statements.js). This makes the module implicitly depend on window.store and can break if makePdfZip is invoked in a different runtime context.

Suggested change

/* globals obis, store */

import { makePromise } from '@/cjs/promises'

import { getGenerators } from '@/obis/generators'

import { dateTimeString, zeroPad } from '@/obis/utils/dates'

import { compatMakeStatements } from '@/obis/statements'

/* globals obis */

import { makePromise } from '@/cjs/promises'

import { getGenerators } from '@/obis/generators'

import { dateTimeString, zeroPad } from '@/obis/utils/dates'

import { compatMakeStatements } from '@/obis/statements'

import { store } from '@/obis/store'

Copilot · 2026-03-07T21:43:23Z

src/common/obis/zip.js

+const DOWNLOAD_DELAY_MS = 500  // Delay between saveAs calls to avoid browser blocking
+
+async function makePdfZip() {


DOWNLOAD_DELAY_MS is declared but never used. Either remove it, or implement the delay that the comment implies so the code and intent stay in sync.

Copilot · 2026-03-07T21:43:23Z

src/plugins/hsbc-uk/api/transactions.js

+        iscacheable: 'false'
+      }
+    })
+


fetchCreditCardTransactions calls response.json() without checking response.ok. If the API returns a non-2xx status (often HTML or an error payload), this will throw and the error context is lost; add an ok check (and ideally include status/text) before attempting to parse.

Suggested change

if (!response.ok) {

let errorBody = ''

try {

errorBody = await response.text()

} catch (e) {

// Ignore body read errors; we'll still throw with status info.

}

const truncatedBody = errorBody.length > 500 ? errorBody.slice(0, 500) + '...' : errorBody

throw new Error(

`[OBIS] Failed to fetch credit card transactions (page ${pageNum}) for card ${

cardIdentifier?.slice(-30) || 'unknown'

}: ${response.status} ${response.statusText} - ${truncatedBody}`

)

}

Copilot · 2026-03-07T21:43:23Z

src/plugins/hsbc-uk/plugin.js

+
+                if (isCreditCard) {
+                  // Credit cards show masked number like "•••• •••• •••• 6137"
+                  // Extract last 4 digits as identifier


This comment says the last 4 digits are extracted “as identifier”, but in this flow the API identifier used later is accountResponse.id / accountId (passed as cardIdentifier). Consider rewording to avoid implying the last-4 is used as the API identifier.

Suggested change

// Extract last 4 digits as identifier

// Extract last 4 digits for the displayable accountNumber (API identifier remains accountResponse.id)

Copilot · 2026-03-07T21:43:23Z

src/ui/components/obis-overlay-widget/YearsAndActionButtons.jsx

+  // Check if there are any CC accounts
+  const hasCcAccounts = store().accounts.some(a => a.isCreditCard)
+


hasCcAccounts reads store() via a presumed global, but other UI components import store from @/obis/store. Relying on a global here makes the component harder to reuse/test and depends on window.store being set before render; consider importing store instead of using a /* globals store */ annotation.

Copilot · 2026-03-07T21:43:24Z

src/plugins/hsbc-uk/api/statements.js

+//
+// Fetch all CC statement PDFs for an account
+// Returns: Array of { bytes: Uint8Array, filename: string }
+//
+
+const RATE_LIMIT_MS = 5000  // 5 seconds between API requests
+const DEBUG_LIMIT = 0       // Set to 0 for no limit, or a number to limit PDFs fetched
+
+const delay = ms => new Promise(resolve => setTimeout(resolve, ms))
+
+export const fetchAllCcStatementPdfs = async ({ host = '', accountId, cardLastFour, onProgress, onPdfReady } = {}) => {
+  // First get the list of statements


The comment says this returns an array of PDFs, but the function actually returns successCount (a number). Please update the comment to match the return value, or change the implementation to return the described array.

Copilot · 2026-03-07T21:43:24Z

src/plugins/hsbc-uk/plugin.js

            allTransactions.map(transaction => {
              const { date, debit, credit, type, payee, note } = transaction
-              const { accountNumber, sortCode } = store().accounts.find(
+              const account = store().accounts.find(
                acct => acct.id === transaction.accountId
              )


This map(...) call is used for side effects (mutating each transaction) and the returned array is ignored. Using forEach here (or assigning the result of map) would avoid confusion and prevents accidental bugs if this gets refactored later.

prisonblues and others added 3 commits January 12, 2026 01:43

build: rebuild dist

e12fdbc

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

shuckster requested a review from Copilot March 7, 2026 21:37

Copilot started reviewing on behalf of shuckster March 7, 2026 21:38 View session

Copilot AI reviewed Mar 7, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(hsbc-uk): Add credit card support#17

feat(hsbc-uk): Add credit card support#17
prisonblues wants to merge 3 commits intoshuckster:masterfrom
prisonblues:feat/hsbc-cc-support

prisonblues commented Jan 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const DOWNLOAD_DELAY_MS = 500 // Delay between saveAs calls to avoid browser blocking

		async function makePdfZip() {

+    if (!response.ok) {
+      let errorBody = ''
+      try {
+        errorBody = await response.text()
+      } catch (e) {
+        // Ignore body read errors; we'll still throw with status info.
+      }
+      const truncatedBody = errorBody.length > 500 ? errorBody.slice(0, 500) + '...' : errorBody
+      throw new Error(
+        `[OBIS] Failed to fetch credit card transactions (page ${pageNum}) for card ${
+          cardIdentifier?.slice(-30) || 'unknown'
+        }: ${response.status} ${response.statusText} - ${truncatedBody}`
+      )
+    }

	// Extract last 4 digits as identifier
	// Extract last 4 digits for the displayable accountNumber (API identifier remains accountResponse.id)

		// Check if there are any CC accounts
		const hasCcAccounts = store().accounts.some(a => a.isCreditCard)

Conversation

prisonblues commented Jan 12, 2026

Summary

Changes

CC Transaction Support

CC PDF Downloads

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants