Add support for freezing ingress TLS secrets#14
Open
johnmdilley wants to merge 1 commit intoshyiko:masterfrom
Open
Add support for freezing ingress TLS secrets#14johnmdilley wants to merge 1 commit intoshyiko:masterfrom
johnmdilley wants to merge 1 commit intoshyiko:masterfrom
Conversation
Owner
|
Hey John. Thanks for the PR! Any chance you'd be willing to add a test case for |
Author
|
I believe that's covered implicitly in the example files by exercising the TLS secrets - i.e. 9dd9fb4#diff-3923b468d951d238ab424ff3c20097c9R75 has the frozen secret, which uses the rule at 9dd9fb4#diff-3923b468d951d238ab424ff3c20097c9R75 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per https://kubernetes.io/docs/concepts/services-networking/ingress/ ingress resources consume secrets, so these should be frozen too.
There was an issue with the parsing code where the [*] came just before the final key - I believe the fix below solves the issue without breaking other cases.