fix: skip empty documents on config decoding #12656
Open
+48
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes siderolabs#12649 The cryptic error was coming from our code, as it never worked if the decoded node is not mapping node. Also annotate errors with line numbers (or document kinds) to make understanding the problem better, specifically for multi-doc and long configs. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
fix/config-decoding
branch
from
a29f37f to
6aa9b06
Compare
utkuozdemir
approved these changes
Jan 23, 2026
shanduur
approved these changes
Jan 23, 2026
frezbo
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12649
The cryptic error was coming from our code, as it never worked if the decoded node is not mapping node.
Also annotate errors with line numbers (or document kinds) to make understanding the problem better, specifically for multi-doc and long configs.