Fix: use fromSeconds when setting universalExpireTimer #7403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
main
branchpnpm run ready
run passes successfully (more about tests here)Description
When setting a "Default timer for new chats",
DurationInSeconds.fromSeconds(newValue)
should be used instead offromMillis
as thenewValue
number is in seconds. Otherwise the following bug occurs:Tested on macOS 10.15.7 (Signal Desktop: 7.59.0):
To recreate this bug, simply:
This PR fixes this behaviour.