Fix @signalwire/client TS types #1259
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,7 +41,8 @@ | |
| "dependencies": { | ||
| "@signalwire/core": "4.3.0", | ||
| "@signalwire/webrtc": "3.14.0", | ||
| "jwt-decode": "^3.1.2", | ||
| "ts-toolbelt": "^9.6.0" | ||
|
There was a problem hiding this comment. Should There was a problem hiding this comment. @LittorWired actually, it's imported in the code, so it's not just a dev dependency. There was a problem hiding this comment. OK thanks just wanted to double check |
||
| }, | ||
| "devDependencies": { | ||
| "@types/object-path": "^0.11.4" | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please not do this? We always try not to install any packages on the SDK.
Also, even with this lib addition, I see in this PR copilot has highlighted issues with the TS usage. Maybe we need to stop adding these quick fixes and think hard and understand the root cause?
We can take @LittorWired's help as well and understand the TS problems that you have been facing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was from a @LittorWired suggestion already :-)
#1257 (comment)
Since we're heavily relying on Prettify/Compute on this SDK package, I agree that using a well-tested library is better in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it solves one problem but causes two new ones, is it really worth it?
Also, the dependency should be a devDependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to point out in that comment that Prettify/Compute might require a more well-battle-tested utility type if we really want to improve the DX without type "bugs".
Maybe the prettify/compute is not needed at the moment, but to be honest I don't yet fully understand the full context around the root of the issue. I gather it is around type aliases?