Clarify get_signing_link is for self-signing only - #66
Open
mihasicehcek wants to merge 1 commit into
Open
Conversation
The signing link is meant for the current authenticated user to sign the document themselves. It is not a way to send a document to another person for signature. Spell this out in the tool description and docstring so agents route "send for signing" requests to send_invite / embedded invite instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diff CoverageDiff: origin/main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the intent of the
get_signing_linktool. The returned link is meant for the current (authenticated) user to sign the document themselves — it is not a way to send a document to another person for signature. Without this in the description, an agent can mistakenly reach forget_signing_linkwhen the user actually wants to send a document out for signing.Follow-up to #65 (which removed the access token from these links).
Changes
tools/signnow.py— expand theget_signing_linktooldescriptionand docstring to state it is for self-signing only, and point tosend_invite/ the embedded invite tools for sending a document to someone else.Tests
Docs/description-only change to an existing tool; no behavior change.
pytest tests/unit/→ 759 passed, 1 skipped; ruff + mypy green.🤖 Generated with Claude Code