feat(spec-tests): typing & ssz infrastructure #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts. Could you please resolve them @Zacholme7? 🙏 |
mergify
bot
added
waiting-on-author
and removed
ready-for-review
mergify
bot
added
ready-for-review
|
This pull request has merge conflicts. Could you please resolve them @Zacholme7? 🙏 |
mergify
bot
added
waiting-on-author
and removed
ready-for-review
mergify
bot
added
ready-for-review
dknopik
reviewed
Jul 14, 2025
Comment on lines
-26
to
49
| impl TryFrom<u64> for PartialSignatureKind { | ||
| type Error = (); | ||
|
|
||
| fn try_from(value: u64) -> Result<Self, Self::Error> { | ||
| impl From<u64> for PartialSignatureKind { | ||
| fn from(value: u64) -> Self { | ||
| match value { | ||
| 0 => Ok(PartialSignatureKind::PostConsensus), | ||
| 1 => Ok(PartialSignatureKind::RandaoPartialSig), | ||
| 2 => Ok(PartialSignatureKind::SelectionProofPartialSig), | ||
| 3 => Ok(PartialSignatureKind::ContributionProofs), | ||
| 4 => Ok(PartialSignatureKind::ValidatorRegistration), | ||
| 5 => Ok(PartialSignatureKind::VoluntaryExit), | ||
| _ => Err(()), | ||
| 0 => PartialSignatureKind::PostConsensus, | ||
| 1 => PartialSignatureKind::RandaoPartialSig, | ||
| 2 => PartialSignatureKind::SelectionProofPartialSig, | ||
| 3 => PartialSignatureKind::ContributionProofs, | ||
| 4 => PartialSignatureKind::ValidatorRegistration, | ||
| 5 => PartialSignatureKind::VoluntaryExit, | ||
| _ => panic!("Invalid PartialSignatureKind value: {value}"), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
To derive Deserialize on the PartialSignatureKind for reading in the test files it requires From not TryFrom
dknopik
added
waiting-on-author
and removed
ready-for-review
Zacholme7
changed the title
|
Did some cleanup and I think this is in a mergable place now. Merging into new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This contains all parsing logic, ssz typing, and tree hashing needed for the current state of the spec tests. Contains the logic from #377 alongside some additions