chore: Add coauthor info to merge commits #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jimmy Chen <[email protected]>
|
Some required checks have failed. Could you please take a look @dknopik? 🙏 |
mergify
bot
added
waiting-on-author
and removed
ready-for-review
dknopik
added
ready-for-review
|
Some required checks have failed. Could you please take a look @dknopik? 🙏 |
mergify
bot
added
waiting-on-author
and removed
ready-for-review
diegomrsantos
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
After we introduced mergify, co-authors stopped showing up in merge commits.
Proposed Changes
To make sure everyone is credited for their work, add the
Co-Authored-By:footer(s) to the commits generated by mergify. This is based on the author info of the individual commits in the PR.Additional Info
Stolen from @jimmygchen: sigp/lighthouse#7993
Intentionally targets stable. Pls no touch, I'll take care of merging after approval.