Skip to content

Conversation

macladson
Copy link
Member

@macladson macladson commented May 15, 2024

EIP: https://eips.ethereum.org/EIPS/eip-7495

See ssz_derive tests for example of ergonomics.

Outstanding Work

  • SSZ
    • Encode
      • StableContainer
      • Profile
    • Decode
      • StableContainer
      • Profile
  • TreeHash changes
    • StableContainer
    • Profile

Considerations

  • Does not touch the custom encoding/decoding implementation (for example when using #[ssz(with = "some_function")]) so these might not work as expected.
  • Need a more ergonomic way to restrict fields to Option.

@macladson macladson force-pushed the stable-container branch 3 times, most recently from 5165c33 to e8726dd Compare May 17, 2024 12:48
@macladson macladson changed the title [WIP] Implement EIP-7495: Stable Containers [WIP] Implement EIP-7495: StableContainer May 17, 2024
@delbonis
Copy link

What is the status of this PR?

@michaelsproul
Copy link
Member

@delbonis We got hard blocked on some issues in our TreeHash/Milhouse library.

The full list of things we tried is:

Sorry that those notes are fairly messy, the root of the problem is that our current BeaconState struct doesn't derive TreeHash due to requiring mutable access to its Milhouse list/vector types. We were hoping to fix this before merging the feature, otherwise it's useless for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants