Add BlocksBy* protocols with specific block_root #7096
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ByRange` requests (sigp#7058) * Load block roots from fork choice where possible to avoid loading state from disk when serving block by range requests. * Check if the start slot is newer than finalization (`start_slot >= finalized_slot`), and use fork choice in that case.
sigp#7066) * handle bbr across finalized slot gracefully * sort deps * Michael's off-by-one corrections --------- Co-authored-by: Michael Sproul <[email protected]>
|
Some required checks have failed. Could you please take a look @dapplion? 🙏 |
mergify
bot
added
the
waiting-on-author
|
This pull request has merge conflicts. Could you please resolve them @dapplion? 🙏 |
|
Hi @dapplion, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time. |
mergify
bot
added
the
stale
|
@dapplion I'm reopening this - i assume you still want this? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
@AgeManning pointed to me that we can have experimental ReqResp protocols in Lighthouse :) so here we go
Implements
a new ReqResp protocol to make have better attributability of malicious sync peers when range syncing. See the spec PR for more details
Proposed Changes
Since the spec is not agreed upon yet, this PR implements a new namespaces "feature" protocol suffixed by the spec PR number:
BlocksByRangeV2_3845,BlobsByRangeV1_3845,DataColumnsByRangeV1_3845. Note that we may have a newBlocksByRangeV3protocol in the future before the 3845 feature is merged, thus havingBlocksByRangeV2_3845andBlocksByRangeV3_3845.These new protocol can exist in Lighthouse nodes only who will use them between themselves. They can also be deprecated in the future without coordination if the feature is merged or abandoned.
Requester changes
On a syncing chain of type Head that with peers with a Status message (head_root, head_slot), include
head_rootin the request.Server changes
BlocksByRangerequests #7058 + Split block root lookups between fork choice and store on BBR response #7066 to have fork-choice accessThen instead of querying the fork-choice for blocks with the head root, query by the request block_root.