Use async RwLock for the VC's initialized_validators
#7423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
work-in-progress
michaelsproul
changed the title
initialized_validators
|
Was poking around a bit here trying to get things to compile and found a subtle tracing issue info!(
voting_validators = validator_store.num_voting_validators().await,
"Loaded validator keypair store"
);
Calling a future inside a tracing macro isn't |
|
Oh nice find! Good to know! |
michaelsproul
added
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Remove a
parking_lot::RwLockReadGuardwhich was being held across an await in the VC.Possibly addressing:
6.14.4->6.14.7#7403Proposed Changes
Use a
tokio::sync::RwLockwhich requiresawaitto be unlocked.Unfortunately this has a huge ripple effect, with many functions needing to be async 🙄
I've been grinding through this refactor for hours and it isn't quite finished yet. I'm offline until May 13. If anyone wants to pick this up before then just comment below.