Skip to content

Conversation

PoulavBhowmick03
Copy link
Contributor

Issue Addressed

Potentially Fixes #6572

Proposed Changes

  • Removed DataColumnInfo from beacon_node/store/src/metadata.rs and it's metadata
  • Removed data column initialization in beacon chain builder
  • Simplified RPC methods to use data_availability_boundary_slot directly
  • Removed database operations for data column info storage/retrieval
  • Cleaned up unused imports

@PoulavBhowmick03 PoulavBhowmick03 requested a review from jxs as a code owner June 21, 2025 17:08
@eserilev eserilev added code-quality das Data Availability Sampling optimization Something to make Lighthouse run more efficiently. database ready-for-review The code is ready for review and removed code-quality labels Jun 22, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this change will also require a DB schema change in order to clean up the old data (to delete it). We'll also need a downgrade which recreates it. Seeing as the value is informational, the downgrade could just set the oldest data column slot to the split slot.

We are planning out schema upgrades and allocating versions in this issue:

@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jun 23, 2025
@mergify mergify bot closed this Jul 23, 2025
Copy link

mergify bot commented Jul 23, 2025

Hi @PoulavBhowmick03, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time.

@mergify mergify bot added the stale Stale PRs that have been inactive and is now outdated label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling database optimization Something to make Lighthouse run more efficiently. stale Stale PRs that have been inactive and is now outdated waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants