Skip to content

feat(val): Reconstructed Validator Attestation Service to construct SingleAttestation directly #7649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

feat(val): Reconstructed Validator Attestation Service to construct SingleAttestation directly #7649

wants to merge 1 commit into from
+160 −61

Conversation

PoulavBhowmick03
Copy link
Contributor

Issue Addressed

Fixes #7634

@eserilev eserilev added code-quality val-client Relates to the validator client binary ready-for-review The code is ready for review and removed val-client Relates to the validator client binary labels Jun 26, 2025
@eserilev eserilev self-requested a review June 26, 2025 14:52
@eserilev eserilev added the val-client Relates to the validator client binary label Jun 26, 2025
@PoulavBhowmick03 PoulavBhowmick03 force-pushed the reconstruct/validator_attestation branch from cbf463e to 5e271ab Compare July 12, 2025 20:54
eserilev
eserilev requested changes Jul 21, 2025
View reviewed changes
Copy link
Member

@eserilev eserilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go a bit further in this refactor

  • In becon_chain.rs we have produce_unaggregated_attestation, this should produce a SingleAttestation instead of an Attestation
  • We can safely remove the Attestation empty_for_signing method. It is used in various test cases, so those will also need to be updated to use SingleAttestation::empty_for_signing
  • the ValidatorStore trait has sign_attestation method that should probably accept a SingleAttestation to sign instead of an Attestation. This will affect downstream tests

@eserilev eserilev added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eserilev eserilev eserilev requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
code-quality val-client Relates to the validator client binary waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PoulavBhowmick03 @eserilev