-
Notifications
You must be signed in to change notification settings - Fork 906
Transition network key to hex format #7665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Noting that this isn't backwards compat because old versions of LH won't work with the hex-formatted keys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #7881. You may have to fix your CI before adding the pull request to the queue again. |
@mergify requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Issue Addressed
#7181
Proposed Changes
Instead of storing the network key as binary data we store it as hex, allowing users to modify it via the file.
We can read old-binary forms, however we will migrate binary to hex as it will be the new standard.