Skip to content

Conversation

AgeManning
Copy link
Member

@AgeManning AgeManning commented Jun 30, 2025

Issue Addressed

#7181

Proposed Changes

Instead of storing the network key as binary data we store it as hex, allowing users to modify it via the file.

We can read old-binary forms, however we will migrate binary to hex as it will be the new standard.

@AgeManning AgeManning requested a review from jxs as a code owner June 30, 2025 02:04
@michaelsproul michaelsproul added backwards-incompat Backwards-incompatible API change v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky labels Jun 30, 2025
@michaelsproul
Copy link
Member

Noting that this isn't backwards compat because old versions of LH won't work with the hex-formatted keys.

@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Aug 6, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 15, 2025
mergify bot added a commit that referenced this pull request Aug 15, 2025
Copy link

mergify bot commented Aug 15, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #7881.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@jimmygchen
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Aug 15, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 9200042 into sigp:unstable Aug 15, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompat Backwards-incompatible API change Networking ready-for-merge This PR is ready to merge. v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants