Skip to content

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Jun 30, 2025

Proposed Changes

This PR implements some heuristics to check for breaking database changes. The goal is to prevent accidental changes to the database schema occurring without a version bump.

Additional Info

For example, this test would fail on the following PRs, forcing a schema change/test update:

Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@michaelsproul michaelsproul added the ready-for-merge This PR is ready to merge. label Jun 30, 2025
mergify bot added a commit that referenced this pull request Jun 30, 2025
mergify bot added a commit that referenced this pull request Jun 30, 2025
Copy link

mergify bot commented Jun 30, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #7669 has been manually updated.

You can check the last failing draft PR here: #7671.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

mergify bot added a commit that referenced this pull request Jun 30, 2025
mergify bot added a commit that referenced this pull request Jun 30, 2025
Copy link

mergify bot commented Jun 30, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #7672.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify bot added a commit that referenced this pull request Jun 30, 2025
@mergify mergify bot merged commit c1f94d9 into sigp:unstable Jun 30, 2025
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database ready-for-merge This PR is ready to merge. test improvement Improve tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants