Skip to content

Validator manager import to allow overriding fields with CLI flag #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: unstable
Choose a base branch
from
Open

Validator manager import to allow overriding fields with CLI flag #7684

wants to merge 6 commits into from

Conversation

chong-he
Copy link
Member

@chong-he chong-he commented Jul 1, 2025

@chong-he chong-he added val-client Relates to the validator client binary ready-for-review The code is ready for review UX-and-logs labels Jul 1, 2025
@mergify Mergify
Copy link

mergify bot commented Jul 1, 2025

Some required checks have failed. Could you please take a look @chong-he? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jul 1, 2025
chong-he
chong-he commented Jul 1, 2025
View reviewed changes
validator_manager/src/import_validators.rs
})?;

// Log the overridden note when one or more flags is supplied
if let Some(override_fee_recipient) = fee_recipient {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logging is very repetitive, I put them here mainly because the overriding of suggested-fee-recipient, but thought we should do the same for others too. Not sure if we want this logging?

@chong-he chong-he added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jul 2, 2025
@mergify Mergify
Copy link

mergify bot commented Jul 2, 2025

Some required checks have failed. Could you please take a look @chong-he? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jul 2, 2025
@chong-he chong-he added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jul 2, 2025
@michaelsproul michaelsproul requested a review from macladson July 10, 2025 05:14
@michaelsproul
Copy link
Member

@macladson would you mind reviewing this? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macladson macladson Awaiting requested review from macladson

Assignees
No one assigned
Labels
ready-for-review The code is ready for review UX-and-logs val-client Relates to the validator client binary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chong-he @michaelsproul