Skip to content

Conversation

PoulavBhowmick03
Copy link
Contributor

@PoulavBhowmick03 PoulavBhowmick03 commented Jul 4, 2025

Issue Addressed

Fixes #7697

Proposed Changes

  • Introduced a const MAX_RECONSTRUCTION_DELAY of 1s
  • A new ReconstructionBound struct to group together the DelayKey and the first enqueue.
  • A new if condition to check if the duration since the first enqueue surpasses the MAX_RECONSTRUCTION_DELAY

@chong-he chong-he added ready-for-review The code is ready for review das Data Availability Sampling labels Jul 7, 2025
@jimmygchen
Copy link
Member

@PoulavBhowmick03 we've decided to go with a different approach implemented in #7976, as we think reconstruction is better triggered at the 3s so we have enough time to reconstruct before the attestation deadline.

Thanks a lot for the PR 🙏

@jimmygchen jimmygchen closed this Sep 9, 2025
@PoulavBhowmick03
Copy link
Contributor Author

@PoulavBhowmick03 we've decided to go with a different approach implemented in #7976, as we think reconstruction is better triggered at the 3s so we have enough time to reconstruct before the attestation deadline.

Thanks a lot for the PR 🙏

Yes I went through the PR and spoke to Eitan about it, as the slot aware approach makes more sense for the reconstruction.
Anytime, looking forward to working on more stuffs and learning through it ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants