-
Notifications
You must be signed in to change notification settings - Fork 893
Instrument tracing spans for block processing and import #7816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit 52bc831 Author: Michael Sproul <[email protected]> Date: Mon Jul 21 13:56:44 2025 +1000 Remove tracing instrumentation # Conflicts: # beacon_node/network/src/sync/manager.rs # beacon_node/network/src/sync/peer_sampling.rs
… into tracing-spans-test
Just reading the doc on spans, I think some of the async functions are instrumented incorrectly, will revisit this on Monday! I've checked all |
…tly impacting component processing traces
3c57222
to
4af2855
Compare
This is brilliant. I'm gonna play around with this later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Just a few minor nits from me, LGTM
beacon_node/beacon_chain/src/data_availability_checker/overflow_lru_cache.rs
Show resolved
Hide resolved
beacon_node/beacon_chain/src/data_availability_checker/overflow_lru_cache.rs
Show resolved
Hide resolved
# Conflicts: # beacon_node/beacon_chain/src/data_availability_checker/overflow_lru_cache.rs # beacon_node/beacon_chain/src/fetch_blobs/mod.rs # beacon_node/lighthouse_network/src/service/mod.rs
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
@eserilev thanks for the review 🙏 |
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #7842. You may have to fix your CI before adding the pull request to the queue again. |
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #7843. You may have to fix your CI before adding the pull request to the queue again. |
Issue Addressed
#7815
service_name
may be lost.process_gossip_data_column_sidecar
process_gossip_blob
process_gossip_block
process_rpc_block
process_rpc_blobs
process_rpc_custody_columns
process_chain_segment
PendingComponents
lifecyclepending_components
To test locally:
--telemetry-collector-url http://localhost:4317
Some captured traces can be found here: https://hackmd.io/@jimmygchen/r1sLOxPPeg
Removing the old spans seem to have reduced the memory usage quite a lot - i think we were using them on long running tasks and too excessively:
