Fix reprocess queue memory leak #8065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fix a memory leak in the reprocess queue.
Proposed Changes
If the vec of attestation IDs for a block is never evicted from the reprocess queue by a
BlockImportedevent, then it stays in the map forever consuming memory. The fix is to remove the entry when its last attestation times out. We do similarly for light client updates.In practice this will only occur if there is a race between adding an attestation to the queue and processing the
BlockImportedevent, or if there are attestations for block roots that we never import (e.g. random block roots, block roots of invalid blocks).Additional Info