Skip to content

Remove bitflags dependency and replace with custom implementation#50

Merged
sile merged 7 commits intomasterfrom
remove-bitflags
Sep 18, 2025
Merged

Remove bitflags dependency and replace with custom implementation#50
sile merged 7 commits intomasterfrom
remove-bitflags

Conversation

@sile
Copy link
Copy Markdown
Owner

@sile sile commented Sep 18, 2025

No description provided.

@sile sile requested a review from Copilot September 18, 2025 10:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the external bitflags dependency and replaces it with a custom implementation to reduce external dependencies. The changes maintain the same API surface while implementing bitwise operations directly.

  • Remove bitflags crate dependency from Cargo.toml
  • Replace bitflags macro usage with custom Flags struct implementation
  • Update clippy lint from allow to expect for better future compatibility

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/node.rs Implements custom Flags struct with bitwise operations to replace bitflags macro
src/lib.rs Removes bitflags extern crate declaration and updates clippy lint directive
Cargo.toml Removes bitflags dependency from dependencies section

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sile sile merged commit cfe3000 into master Sep 18, 2025
12 checks passed
@sile sile deleted the remove-bitflags branch September 18, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants