Build FWLite for iOS #1617

megahirt · 2025-04-22T18:20:15Z

This is a draft PR to get a iOS publishing workflow in place

I resolved a build issue where the iOS MAUI build was looking for appicon but couldn't find it. It appears that MAUI iOS has hard-coded this because I cannot find it referenced anywhere.

iOS expects app icons to be perfectly square at 1024x1024 so I decided to tweak the SVGs to be perfectly square. Also produced some PNGs

This tells the content area to add iOS safe area margin so that there are not UI collisions with the iOS status bar. See https://learn.microsoft.com/en-us/dotnet/maui/ios/platform-specifics/page-safe-area-layout?view=net-maui-9.0

We need to specify the name of the Apple Distribution certificate for SIL

coderabbitai · 2025-04-22T18:20:22Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

.github/workflows/fw-lite-ios.yaml

+    name: Publish FW Lite app for iOS
+    #needs: build-and-test
+    timeout-minutes: 30
+    runs-on: macos-latest
+    env:
+      APPLE_CERTIFICATE: ${{ secrets.SIL_APPLE_DISTRIBUTION_CERTIFICATE_BASE64 }}
+      APP_STORE_CONNECT_KEY_ID: ${{ secrets.APPLE_APPSTORECONNECT_KEY_ID }}
+      APP_STORE_CONNECT_ISSUER_ID: ${{ secrets.APPLE_APPSTORECONNECT_ISSUER_ID }}
+      APP_STORE_CONNECT_PRIVATE_KEY: ${{ secrets.APPLE_APPSTORECONNECT_PRIVATE_KEY }}
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          submodules: true
+      #- uses: actions/download-artifact@v4
+        #with:
+          #name: fw-lite-viewer-js
+          #path: ${{ env.VIEWER_BUILD_OUTPUT_DIR }}
+      - uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: '9.x'
+      - uses: maui-actions/apple-provisioning@v4
+        with:
+          certificate: APPLE_CERTIFICATE
+          certificate-passphrase: ${{ secrets.SIL_APPLE_DISTRIBUTION_CERTIFICATE_PASSPHRASE }}
+          bundle-identifiers: 'org.sil.FwLiteMaui'
+          profile-types: 'IOS_APP_STORE'
+
+      #- name: Setup Maui
+        #run: dotnet workload install maui
+
+      #- name: Publish iOS
+        #working-directory: backend/FwLite/FwLiteMaui
+        #run: dotnet publish -f net9.0-ios --artifacts-path ../artifacts
+
+      #- name: Upload FWLite App artifacts
+        #uses: actions/upload-artifact@v4
+        #with:
+          #name: fw-lite-ios
+          #if-no-files-found: error
+##          path looks like this: backend/FwLite/artifacts/publish/FwLiteMaui/release_net9.0-android/org.sil.fwlitemaui-signed.apk
+          #path: backend/FwLite/artifacts/publish/*


hahn-kev · 2025-04-23T02:16:24Z

backend/FwLite/FwLiteMaui/Resources/AppIcon/appicon.svg

so I think the reference to this file is in backend/FwLite/FwLiteMaui/Platforms/iOS/Info.plist could we change the XSAppIconAssets key there to point at the existing icon? Right now it's Assets.xcassets/appicon.appiconset so maybe it just needs to be changed to Assets.xcassets/logo_light.appiconset?

megahirt added 4 commits April 14, 2025 21:25

use appicon.svg because iOS won't build otherwise

d2a9631

I resolved a build issue where the iOS MAUI build was looking for appicon but couldn't find it. It appears that MAUI iOS has hard-coded this because I cannot find it referenced anywhere.

add 1024x1024 square logos

197953b

iOS expects app icons to be perfectly square at 1024x1024 so I decided to tweak the SVGs to be perfectly square. Also produced some PNGs

use iOS safe area

70cc6bc

This tells the content area to add iOS safe area margin so that there are not UI collisions with the iOS status bar. See https://learn.microsoft.com/en-us/dotnet/maui/ios/platform-specifics/page-safe-area-layout?view=net-maui-9.0

add properties for iOS code signing to MAUI csproj file

b95f668

We need to specify the name of the Apple Distribution certificate for SIL

github-advanced-security bot found potential problems Apr 22, 2025

View reviewed changes

.github/workflows/fw-lite-ios.yaml Fixed Show fixed Hide fixed

megahirt force-pushed the build-ios branch 3 times, most recently from fc5e871 to 3499af6 Compare April 22, 2025 19:38

github-advanced-security bot found potential problems Apr 22, 2025

View reviewed changes

.github/workflows/fw-lite-ios.yaml Fixed Show fixed Hide fixed

.github/workflows/fw-lite-ios.yaml Fixed Show fixed Hide fixed

megahirt force-pushed the build-ios branch from 3499af6 to a5a8452 Compare April 22, 2025 20:02

github-advanced-security bot found potential problems Apr 22, 2025

View reviewed changes

GHA for publishing iOS (for testing)

475b02c

megahirt force-pushed the build-ios branch from a5a8452 to 475b02c Compare April 22, 2025 20:12

hahn-kev reviewed Apr 23, 2025

View reviewed changes

hahn-kev added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Jun 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Build FWLite for iOS #1617

Build FWLite for iOS #1617

Uh oh!

megahirt commented Apr 22, 2025

Uh oh!

coderabbitai bot commented Apr 22, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

hahn-kev Apr 23, 2025

Uh oh!

Uh oh!

Uh oh!

Build FWLite for iOS #1617

Are you sure you want to change the base?

Build FWLite for iOS #1617

Uh oh!

Conversation

megahirt commented Apr 22, 2025

Uh oh!

coderabbitai bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

hahn-kev Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot commented Apr 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)