E2e test fw lite #1866

hahn-kev · 2025-07-31T09:40:48Z

I started working on this with Kiro, but then ditched it as it was going in the wrong direction and creating a bunch of fluff

…d certs

coderabbitai · 2025-07-31T09:41:09Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch e2e-test-fw-lite

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

# Conflicts: # .github/workflows/fw-lite.yaml

github-actions · 2025-07-31T10:00:32Z

UI unit Tests

1 files ± 0 42 suites +39 24s ⏱️ +24s
101 tests + 91 99 ✅ + 89 0 💤 ±0 2 ❌ +2
135 runs +125 133 ✅ +123 0 💤 ±0 2 ❌ +2

For more details on these failures, see this check.

Results for commit e1166d3. ± Comparison against base commit 9b3e191.

This pull request removes 10 and adds 101 tests. Note that renamed tests count towards both.

src/index.test.ts ‑ password hashing > can hash a pw using sha1
src/lib/i18n/i18n.test.ts ‑ buildRegionalLocaleRegex > should find all regional locales for available locales
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return en by default
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return en if no user locale is provided and acceptLanguageHeader does not have any supported locales
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return regional locale from acceptLanguageHeader if it has a higher quality rating than the regionless locale
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return supported locale from acceptLanguageHeader with highest quality rating if no user locale is provided
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader does not provide a regional/more specific locale
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader does not provide a regional/more specific locale with a higher quality rating
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader is not provided
src/lib/user.test.ts ‑ jwtToUser > should convert a jwt token to a LexAuthUser

src/fw-lite-launcher.test.ts ‑ FwLiteLauncher > basic functionality > should handle shutdown when not running
src/fw-lite-launcher.test.ts ‑ FwLiteLauncher > basic functionality > should return false when not launched
src/fw-lite-launcher.test.ts ‑ FwLiteLauncher > basic functionality > should throw error if already running
src/fw-lite-launcher.test.ts ‑ FwLiteLauncher > basic functionality > should throw error if binary does not exist
src/fw-lite-launcher.test.ts ‑ FwLiteLauncher > basic functionality > should throw error when getting base URL while not running
src/fw-lite-launcher.test.ts ‑ FwLiteLauncher > configuration validation > should handle optional configuration parameters
src/fw-lite-launcher.test.ts ‑ FwLiteLauncher > configuration validation > should validate launch configuration parameters
src/fw-lite-launcher.test.ts ‑ FwLiteLauncher > launcher state management > should maintain proper state transitions
src/fw-lite-launcher.test.ts ‑ FwLiteLauncher > port finding functionality > should be able to find available ports
src/fw-lite-launcher.test.ts ‑ FwLiteLauncher > real FW Lite server integration > should handle multiple launch attempts gracefully
…

♻️ This comment has been updated with latest results.

.github/workflows/fw-lite.yaml

frontend/viewer/tests/e2e/helpers/test-data.ts

github-actions · 2025-07-31T10:02:21Z

C# Unit Tests

130 tests ±0 130 ✅ ±0 19s ⏱️ ±0s
20 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit e1166d3. ± Comparison against base commit 9b3e191.

♻️ This comment has been updated with latest results.

argos-ci · 2025-08-01T04:01:38Z

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Sep 10, 2025, 3:41 AM

# Conflicts: # frontend/viewer/src/home/Server.svelte # frontend/viewer/tests/snapshots/playwright.config.ts

…ial errors on startup.

…red shutdown support

.github/workflows/fw-lite.yaml

+    name: E2E Tests
+    needs: [publish-linux]
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          submodules: true
+
+      - uses: actions/download-artifact@v4
+        id: download-artifact
+        with:
+          name: fw-lite-web-linux
+          path: fw-lite-web-linux
+      - name: set execute permissions
+        run: chmod +x ${{ steps.download-artifact.outputs.download-path }}/*/FwLiteWeb
+      - name: Install Task
+        uses: arduino/setup-task@b91d5d2c96a56797b48ac1e0e89220bf64044611 #v2
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+      - uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # v4.0.0
+        with:
+          package_json_file: 'frontend/package.json'
+      - uses: actions/setup-node@v4
+        with:
+          node-version-file: './frontend/package.json'
+          cache: 'pnpm'
+          cache-dependency-path: './frontend/pnpm-lock.yaml'
+      - name: Prepare frontend
+        working-directory: frontend
+        run: |
+          pnpm install
+      - name: Test fw lite launcher
+        working-directory: frontend/viewer
+        env:
+          FW_LITE_BINARY_PATH: ${{ steps.download-artifact.outputs.download-path }}/release_linux-x64/FwLiteWeb
+        run: task e2e-test-helper-unit-tests
+
+      - uses: ./.github/actions/setup-k8s
+        with:
+          lexbox-api-tag: develop
+          ingress-controller-port: '6579' # todo, figure out if we can use https as it's required for the tests
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+      - name: Set up Playwright dependencies
+        working-directory: frontend/viewer
+        run: pnpm exec playwright install --with-deps
+
+      - name: Run E2E tests
+        working-directory: frontend/viewer
+        env:
+          FW_LITE_BINARY_PATH: ${{ steps.download-artifact.outputs.download-path }}/release_linux-x64/FwLiteWeb
+          TEST_SERVER_PORT: 6579
+        run: task test:e2e
+
+      - name: Upload Playwright test results and traces (on failure)
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: fw-lite-e2e-test-results
+          if-no-files-found: ignore
+          path: |
+            frontend/viewer/tests/e2e/test-results/


To fix the identified problem, add an explicit permissions block to the workflow, to ensure the GITHUB_TOKEN used by the job is limited to the least privileges necessary. For e2e-test, none of the shown steps perform actions that modify repository data, so contents: read is sufficient.
The best way to implement this is to add a permissions block with contents: read to the e2e-test job in .github/workflows/fw-lite.yaml, immediately under the job name or any existing needs, runs-on, or timeout-minutes keys (inside the e2e-test: job definition).

hahn-kev added 23 commits July 16, 2025 10:45

e2e specs

d0088b8

create e2e test directory

837732f

add a health check endpoint

c2eb8bf

implement fw lite launcher and tests

27d6186

setup test data managment

46b33ed

setup server operations helper

9478006

ensure e2e test server is used for lexbox server

93c9aaf

set environment to development to allow oauth to work with self signe…

bcb0bef

…d certs

main integration tests

8f0b38e

rename config server to lexboxServer for clarity

0a3ac6a

put an id on the server div for testing

fc01abe

ensure we never redirect to the login page, instead redirect home

28b2ab0

fix integration tests so they work

2ff9146

get some more tests passing

14871fb

cleanup unused stuff

2d61419

Merge branch 'develop' into e2e-test-fw-lite

ff70b5f

move tests into snapshots folder, along with their playwright config

27afd18

split playwright tests into snapshot and e2e

4d5b458

rework the tests, add helper endpoint for deleting a project

8349a74

ignore test results

73e8527

update ci to run snapshot tests

53fcfe5

add e2e workflow job

b85e0a2

cleanup a bunch of junk from the AI

48734fc

hahn-kev marked this pull request as draft July 31, 2025 09:40

github-actions bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Jul 31, 2025

hahn-kev added 2 commits July 31, 2025 16:59

pre test the fw lite launcher

26213dd

Merge branch 'develop' into e2e-test-fw-lite

6cb67d6

# Conflicts: # .github/workflows/fw-lite.yaml

github-advanced-security bot found potential problems Jul 31, 2025

View reviewed changes

.github/workflows/fw-lite.yaml Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Jul 31, 2025

View reviewed changes

frontend/viewer/tests/e2e/helpers/test-data.ts Dismissed Show dismissed Hide dismissed

correct pnpm script in taskfile

049787d

hahn-kev added 6 commits August 5, 2025 10:03

don't hardcode the binary path for the launcher tests

b4f3058

ensure the correct path for permissions

af03204

Merge branch 'develop' into e2e-test-fw-lite

f83dca4

# Conflicts: # frontend/viewer/src/home/Server.svelte # frontend/viewer/tests/snapshots/playwright.config.ts

Handle null checks in Directory.SetCurrentDirectory to avoid potent…

85fd9ff

…ial errors on startup.

Improve shutdown handling for FW Lite on Windows and add stdin-trigge…

dacc37f

…red shutdown support

Upload Playwright test results and traces on failure in FW Lite workflow

29404de

github-advanced-security bot found potential problems Sep 9, 2025

View reviewed changes

log server output in playwright test output folder

e1166d3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

E2e test fw lite #1866

E2e test fw lite #1866

hahn-kev commented Jul 31, 2025

Uh oh!

coderabbitai bot commented Jul 31, 2025 •

edited

Loading

Review skipped

Uh oh!

github-actions bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

argos-ci bot commented Aug 1, 2025 •

edited

Loading

Uh oh!

Check warning

Copilot Autofix

Uh oh!

@@ -408,6 +408,8 @@
               e2e-test:
                 name: E2E Tests
+                permissions:
+                  contents: read
                 needs: [publish-linux]
                 runs-on: ubuntu-latest
                 steps:

Uh oh!

E2e test fw lite #1866

Are you sure you want to change the base?

E2e test fw lite #1866

Conversation

hahn-kev commented Jul 31, 2025

Uh oh!

coderabbitai bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

UI unit Tests

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

C# Unit Tests

Uh oh!

argos-ci bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Check warning

Copilot Autofix

Uh oh!

coderabbitai bot commented Jul 31, 2025 •

edited

Loading

github-actions bot commented Jul 31, 2025 •

edited

Loading

github-actions bot commented Jul 31, 2025 •

edited

Loading

argos-ci bot commented Aug 1, 2025 •

edited

Loading