Skip to content

Conversation

TaperChipmunk32
Copy link
Collaborator

@TaperChipmunk32 TaperChipmunk32 commented Sep 10, 2025

This PR fixes an issue with translate using the base model even when a checkpoint is present.


This change is Reviewable

Copy link
Collaborator

@benjaminking benjaminking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjaminking reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mshannon-sil)


silnlp/nmt/translate.py line 404 at r1 (raw file):

        name=args.experiment,
        checkpoint=args.checkpoint,
        save_checkpoints=True,

Could you rename this parameter (just for TranslationTask)? I feel like it's a little misleading here, since you're not saving checkpoints during translation and in fact, you may have it be true even when no checkpoints are saved, for example if you want to inference from the base model.

Copy link
Collaborator Author

@TaperChipmunk32 TaperChipmunk32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @benjaminking and @mshannon-sil)


silnlp/nmt/translate.py line 404 at r1 (raw file):

Previously, benjaminking (Ben King) wrote…

Could you rename this parameter (just for TranslationTask)? I feel like it's a little misleading here, since you're not saving checkpoints during translation and in fact, you may have it be true even when no checkpoints are saved, for example if you want to inference from the base model.

Done.

Copy link
Collaborator

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @benjaminking and @mshannon-sil)

@TaperChipmunk32 TaperChipmunk32 force-pushed the translate-checkpoint-issue branch from 3f62072 to cfd9022 Compare September 15, 2025 20:46
Copy link
Collaborator

@benjaminking benjaminking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjaminking reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mshannon-sil)

@TaperChipmunk32 TaperChipmunk32 merged commit f9ee07e into master Sep 16, 2025
1 check passed
@TaperChipmunk32 TaperChipmunk32 deleted the translate-checkpoint-issue branch September 16, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants