-
-
Notifications
You must be signed in to change notification settings - Fork 7
Fix issue with translate from saved checkpoint #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjaminking reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mshannon-sil)
silnlp/nmt/translate.py
line 404 at r1 (raw file):
name=args.experiment, checkpoint=args.checkpoint, save_checkpoints=True,
Could you rename this parameter (just for TranslationTask
)? I feel like it's a little misleading here, since you're not saving checkpoints during translation and in fact, you may have it be true even when no checkpoints are saved, for example if you want to inference from the base model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @benjaminking and @mshannon-sil)
silnlp/nmt/translate.py
line 404 at r1 (raw file):
Previously, benjaminking (Ben King) wrote…
Could you rename this parameter (just for
TranslationTask
)? I feel like it's a little misleading here, since you're not saving checkpoints during translation and in fact, you may have it be true even when no checkpoints are saved, for example if you want to inference from the base model.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddaspit reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @benjaminking and @mshannon-sil)
3f62072
to
cfd9022
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjaminking reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mshannon-sil)
This PR fixes an issue with translate using the base model even when a checkpoint is present.
This change is