-
-
Notifications
You must be signed in to change notification settings - Fork 5
Add Codecov bundle analysis #3347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3347 +/- ##
=======================================
Coverage 82.12% 82.12%
=======================================
Files 610 610
Lines 36406 36406
Branches 5995 5995
=======================================
Hits 29898 29898
- Misses 5626 5643 +17
+ Partials 882 865 -17 ☔ View full report in Codecov by Sentry. |
Thanks for adding this. I'm hopeful we can reduce our bundle size, but historically it's almost always grown. It seems pretty silly of Codecov to assume the files won't be compressed. Our main.js file is 1018kB over the network, due to our server not supporting Brotli (I think -- Cloudlfare now supports end-to-end Brotli, so I'm guessing it's our server not supporting it. See https://blog.cloudflare.com/this-is-brotli-from-origin/).
|
Uh oh. The migration to application builder and this commit will need reconciled. I'll plan to look into doing this in application builder. |
We can review this PR for its merits against our code repository at present. But it will quickly need reconciled with our frontend's change to application builder 1. Newer versions of Angular use "application builder" (though still support "browser builder") 2. Our frontend moves to application builder in #3338. Angular's application builder partly uses Vite. But we can not just add plugins to its usage of Vite 34. However, we can invert how Vite is used and thus use plugins 4. If we were to do this, I would like to see the transition to the application builder working well before making such a change. Although Angular application builder uses Vite, it really uses esbuild for production 34. But again, it does not seem to be something we can add plugins to as used by angular cli 5. However, we can change our builder to something like @angular-builders/custom-esbuild to use esbuild plugins 6. I took Peter's PR with builder "@angular-builders/custom-webpack:browser" and tried using Codecov provides Footnotes |
@marksvc I think we should keep this PR on ice until after your PR is merged. Codecov analysis does support vite, so we might be able to get it to work then? https://docs.codecov.com/docs/vite-quick-start |
Marking this a draft until Angular upgrade is complete |
50a6992
to
0b96a49
Compare
This PR adds codecov bundle analysis. You can view this information at: https://app.codecov.io/gh/sillsdev/web-xforge/bundles/master
This change is