SF-3554 Create missing chapters when adding draft to a project #3432
Conversation
RaymondLuong3
added
the
will require testing
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| SFProject project = await EnsureProjectPermissionAsync( | ||
| curUserId, | ||
| sfProjectId, | ||
| isServalAdmin: false, | ||
| cancellationToken | ||
| ); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
To fix the problem, simply remove the assignment to the project variable and instead await the method directly as a statement. In src/SIL.XForge.Scripture/Services/MachineApiService.cs, replace SFProject project = await EnsureProjectPermissionAsync(...); with await EnsureProjectPermissionAsync(...);. No further code changes are required since the result is never used. No changes to imports, method signatures, or additional definitions are needed.
| @@ -1175,7 +1175,7 @@ | ||
| ) | ||
| { | ||
| // Ensure that the user has permission | ||
| SFProject project = await EnsureProjectPermissionAsync( | ||
| await EnsureProjectPermissionAsync( | ||
| curUserId, | ||
| sfProjectId, | ||
| isServalAdmin: false, |
Adding a draft to a book that is empty fails to create the missing chapters. We needed a way to detect how many chapters exist in the generated draft and notify the front end so that it can create the missing chapters and update the project texts property. This PR creates a new endpoint that can be used to get the chapters that have drafts.
This change is