Skip to content

ENH PHP 8.5 Support #11912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GuySartorelli merged 1 commit into from
Dec 3, 2025
Merged

ENH PHP 8.5 Support #11912

GuySartorelli merged 1 commit into from
Dec 3, 2025

Conversation

@emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 26, 2025 •
edited
Loading

Issue silverstripe/.github#455

The following changes were made based on the PHP 8.5 changelog:

  • The setAccessible() methods of various Reflection objects have been deprecated, as those no longer have an effect.
  • Using null as an array offset or when calling array_key_exists() is now deprecated.
  • Non-canonical cast names (boolean), (integer), (double), and (binary) have been deprecated.
  • Casting floats that are not representable as ints now emits a warning.
  • The backtick operator as an alias for shell_exec() has been deprecated.

@emteknetnz emteknetnz mentioned this pull request Nov 26, 2025
Closed
5 tasks
@emteknetnz emteknetnz force-pushed the pulls/6/php85 branch 5 times, most recently from 3606f8b to 6cb3aa5 Compare November 27, 2025 00:00
emteknetnz
emteknetnz commented Nov 27, 2025
View reviewed changes
@emteknetnz emteknetnz force-pushed the pulls/6/php85 branch 2 times, most recently from 6438b78 to 689fe5c Compare November 27, 2025 04:54
emteknetnz
emteknetnz commented Dec 1, 2025
View reviewed changes
emteknetnz
emteknetnz commented Dec 1, 2025
View reviewed changes
@emteknetnz emteknetnz marked this pull request as ready for review December 1, 2025 02:31
@emteknetnz emteknetnz marked this pull request as draft December 1, 2025 02:41
emteknetnz
emteknetnz commented Dec 1, 2025
View reviewed changes
@emteknetnz emteknetnz marked this pull request as ready for review December 1, 2025 02:50
@emteknetnz emteknetnz force-pushed the pulls/6/php85 branch 2 times, most recently from e7bda02 to b88507c Compare December 1, 2025 04:58
GuySartorelli
GuySartorelli requested changes Dec 1, 2025
View reviewed changes
GuySartorelli
GuySartorelli requested changes Dec 2, 2025
View reviewed changes
GuySartorelli
GuySartorelli approved these changes Dec 3, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 6095b55 into silverstripe:6 Dec 3, 2025
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/php85 branch December 3, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emteknetnz @GuySartorelli